nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-20 21:16:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make NETINFO clock skew detection work on clients

Browse Source 
An unnecessary routerlist check in the NETINFO clock skew detection in
channel_tls_process_netinfo_cell() was preventing clients from
reporting NETINFO clock skew to controllers.
This commit is contained in:
Taylor Yu 2017-09-14 20:43:52 -05:00
parent 37fed742d1
commit e31a7be161
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changes/bug23532 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (usability, control port):
- Stop making an unnecessary routerlist check in NETINFO clock
skew detection; this was preventing clients from reporting
NETINFO clock skew to controllers. Fixes bug 23532; bugfix on
0.2.4.4-alpha.

5
src/or/channeltls.c
View File

@ -1827,8 +1827,9 @@ channel_tls_process_netinfo_cell(cell_t *cell, channel_tls_t *chan)
/** Warn when we get a netinfo skew with at least this value. */
#define NETINFO_NOTICE_SKEW 3600
if (labs(apparent_skew) > NETINFO_NOTICE_SKEW &&
router_get_by_id_digest(chan->conn->identity_digest)) {
int trusted = router_digest_is_trusted_dir(chan->conn->identity_digest);
(started_here ||
connection_or_digest_is_known_relay(identity_digest))) {
int trusted = router_digest_is_trusted_dir(identity_digest);
clock_skew_warning(TO_CONN(chan->conn), apparent_skew, trusted, LD_GENERAL,
"NETINFO cell", "OR");
}