Merge remote-tracking branch 'tor-gitlab/mr/137' into maint-0.3.5

This commit is contained in:
Nick Mathewson 2020-10-07 08:07:53 -04:00
commit e0e0ef713e
2 changed files with 11 additions and 1 deletions

3
changes/ticket40073 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (relay configuration, crash):
- Avoid a fatal assert() when failing to create a listener connection for an
address that was in use. Fixes bug 40073; bugfix on 0.3.5.1-alpha.

View File

@ -2923,7 +2923,14 @@ retry_all_listeners(smartlist_t *new_conns, int close_all_noncontrol)
&skip, &addr_in_use); &skip, &addr_in_use);
} }
tor_assert(new_conn); /* There are many reasons why we can't open a new listener port so in case
* we hit those, bail early so tor can stop. */
if (!new_conn) {
log_warn(LD_NET, "Unable to create listener port: %s:%d",
fmt_addr(&r->new_port->addr), r->new_port->port);
retval = -1;
break;
}
smartlist_add(new_conns, new_conn); smartlist_add(new_conns, new_conn);