Partially revert "Use tor_addr_from_getsockname() in several places"

This reverts part of commit 6ed384b827, in order to
fix bug 26568.  Bugfix on 0.3.4.1-alpha.
This commit is contained in:
Nick Mathewson 2018-07-02 16:11:02 -04:00
parent cd2be4283c
commit dfdf32404c
2 changed files with 7 additions and 1 deletions

3
changes/bug26568 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (controller):
- Report the port correctly when a port is configured to bind to "auto".
Fixes bug 26568; bugfix on 0.3.4.1-alpha.

View File

@ -1260,12 +1260,15 @@ connection_listener_new(const struct sockaddr *listensockaddr,
gotPort = usePort;
} else {
tor_addr_t addr2;
if (tor_addr_from_getsockname(&addr2, s)<0) {
struct sockaddr_storage ss;
socklen_t ss_len=sizeof(ss);
if (getsockname(s, (struct sockaddr*)&ss, &ss_len)<0) {
log_warn(LD_NET, "getsockname() couldn't learn address for %s: %s",
conn_type_to_string(type),
tor_socket_strerror(tor_socket_errno(s)));
gotPort = 0;
}
tor_addr_from_sockaddr(&addr2, (struct sockaddr*)&ss, &gotPort);
}
#ifdef HAVE_SYS_UN_H
/*