nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 20:33:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix a ubsan warning in addr_mask_get_bits

Browse Source 
ubsan doesn't like us to do (1u<<32) when 32 is wider than
unsigned.  Fortunately, we already special-case
addr_mask_get_bits(0), so we can just change the loop bounds.
This commit is contained in:
Nick Mathewson 2014-03-18 10:49:39 -04:00
parent 2aea6ca326
commit dfdeb6418d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/address.c
View File

@ -1585,7 +1585,7 @@ addr_mask_get_bits(uint32_t mask)
return 0; return 0;
if (mask == 0xFFFFFFFFu) if (mask == 0xFFFFFFFFu)
return 32; return 32;
for (i=0; i<=32; ++i) { for (i=1; i<=32; ++i) {
if (mask == (uint32_t) ~((1u<<(32-i))-1)) { if (mask == (uint32_t) ~((1u<<(32-i))-1)) {
return i; return i;
} }