nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 05:03:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Actually close the stdout pipe on error in process_unix_exec

Browse Source 
When cleaning up after an error in process_unix_exec, the stdin
pipe was being double closed instead of closing both the stdin
and stdout pipes.  This occurred in two places.

Signed-off-by: Kris Katterjohn <katterjohn@gmail.com>
This commit is contained in:
Kris Katterjohn 2019-01-04 13:48:08 -06:00 committed by Nick Mathewson
parent d21fa48cac
commit df1a8a657e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/process/process_unix.c
View File

@ -183,8 +183,8 @@ process_unix_exec(process_t *process)
close(stdin_pipe[1]);
/** Cleanup standard out pipe. */
close(stdin_pipe[0]);
close(stdin_pipe[1]);
close(stdout_pipe[0]);
close(stdout_pipe[1]);
return PROCESS_STATUS_ERROR;
}
@ -281,8 +281,8 @@ process_unix_exec(process_t *process)
close(stdin_pipe[1]);
/** Cleanup standard out pipe. */
close(stdin_pipe[0]);
close(stdin_pipe[1]);
close(stdout_pipe[0]);
close(stdout_pipe[1]);
/** Cleanup standard error pipe. */
close(stderr_pipe[0]);