nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 20:33:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Initialize some locals in socks5 parsing code.

Browse Source 
These confused GCC LTO, which thought they might be used
uninitialized.  I'm pretty sure that as long as 'res' indicates
success, they will always be set to something, but let's unconfuse
the compiler in any case.
This commit is contained in:
Nick Mathewson 2018-09-18 15:13:10 -04:00
parent 370d9922a4
commit dddecee291
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/proto/proto_socks.c
View File

@ -744,7 +744,7 @@ handle_socks_message(const uint8_t *raw_data, size_t datalen,
res = SOCKS_RESULT_MORE_EXPECTED; res = SOCKS_RESULT_MORE_EXPECTED;
goto end; goto end;
} else if (req->socks_version != SOCKS_VER_5) { } else if (req->socks_version != SOCKS_VER_5) {
int have_user_pass, have_no_auth; int have_user_pass=0, have_no_auth=0;
res = parse_socks5_methods_request(raw_data, req, datalen, res = parse_socks5_methods_request(raw_data, req, datalen,
&have_user_pass, &have_user_pass,
&have_no_auth, &have_no_auth,