get rid of a case where we might log a NULL as %s

this doesn't happen in our current code, and now it can't
This commit is contained in:
Roger Dingledine 2017-09-13 22:43:31 -04:00
parent 3247518f22
commit dcd0aea85e

View File

@ -3480,8 +3480,10 @@ write_http_status_line(dir_connection_t *conn, int status,
const char *reason_phrase)
{
char buf[256];
if (!reason_phrase)
reason_phrase = "unspecified";
if (tor_snprintf(buf, sizeof(buf), "HTTP/1.0 %d %s\r\n\r\n",
status, reason_phrase ? reason_phrase : "OK") < 0) {
status, reason_phrase) < 0) {
log_warn(LD_BUG,"status line too long.");
return;
}