nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 13:13:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid sscanf() warnings from openbsd in the unit tests

Browse Source 
OpenBSD doesn't like tricks where you use a too-wide sscanf argument
for a too-narrow array, even when you know the input string
statically.  The fix here is just to use bigger buffers.

Fixes 15582; bugfix on a3dafd3f58 in 0.2.6.2-alpha.
This commit is contained in:
Nick Mathewson 2017-09-12 15:57:25 -04:00
parent bac160b4e0
commit d9e2db1efd
2 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
changes/bug15582 Normal file
View File

@ -0,0 +1,4 @@
o Minor bugfixes (compilation):
- Avoid compiler warnings in the unit tests for running tor_sscanf()
with wide string outputs. Fixes bug 15582; bugfix on 0.2.6.2-alpha.

21
src/test/test_util.c
View File

@ -2500,7 +2500,7 @@ test_util_sscanf(void *arg)
{
unsigned u1, u2, u3;
unsigned long ulng;
char s1[20], s2[10], s3[10], ch;
char s1[20], s2[10], s3[10], ch, *huge = NULL;
int r;
long lng1,lng2;
int int1, int2;
@ -2512,7 +2512,13 @@ test_util_sscanf(void *arg)
tt_int_op(-1,OP_EQ,
tor_sscanf("wrong", "%5c", s1)); /* %c cannot have a number. */
tt_int_op(-1,OP_EQ, tor_sscanf("hello", "%s", s1)); /* %s needs a number. */
tt_int_op(-1,OP_EQ, tor_sscanf("prettylongstring", "%999999s", s1));
/* this will fail because we don't allow widths longer than 9999 */
{
huge = tor_malloc(1000000);
r = tor_sscanf("prettylongstring", "%99999s", huge);
tor_free(huge);
tt_int_op(-1,OP_EQ, r);
}
#if 0
/* GCC thinks these two are illegal. */
test_eq(-1, tor_sscanf("prettylongstring", "%0s", s1));
@ -2618,8 +2624,13 @@ test_util_sscanf(void *arg)
tt_int_op(2,OP_EQ, tor_sscanf("76trombones", "%6u%9s", &u1, s1)); /* %u%s */
tt_int_op(76,OP_EQ, u1);
tt_str_op(s1,OP_EQ, "trombones");
tt_int_op(1,OP_EQ, tor_sscanf("prettylongstring", "%999s", s1));
tt_str_op(s1,OP_EQ, "prettylongstring");
{
huge = tor_malloc(1000);
r = tor_sscanf("prettylongstring", "%999s", huge);
tt_int_op(1,OP_EQ, r);
tt_str_op(huge,OP_EQ, "prettylongstring");
tor_free(huge);
}
/* %s doesn't eat spaces */
tt_int_op(2,OP_EQ, tor_sscanf("hello world", "%9s %9s", s1, s2));
tt_str_op(s1,OP_EQ, "hello");
@ -2843,7 +2854,7 @@ test_util_sscanf(void *arg)
test_feq(d4, 3.2);
done:
;
tor_free(huge);
}
#define tt_char_op(a,op,b) tt_assert_op_type(a,op,b,char,"%c")