nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-20 21:16:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

string: Add extra UTF-8 test cases

Browse Source 
These test cases are validated differently by some
programming languages, because those languages have
incorrect UTF-8 implementations.

We want to make sure that tor validates them correctly.

Closes ticket 32845.
This commit is contained in:
teor 2020-01-07 17:05:48 +10:00
parent 1b63eea66c
commit d62dbb6762
1 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/test/test_util.c
View File

@ -4104,10 +4104,43 @@ test_util_string_is_utf8(void *ptr)
tt_int_op(0, OP_EQ, string_is_utf8("\xed\xbf\xbf", 3));
tt_int_op(1, OP_EQ, string_is_utf8("\xee\x80\x80", 3));
// The maximum legal codepoint, 10FFFF.
// The minimum legal codepoint, 0x00.
tt_int_op(1, OP_EQ, string_is_utf8("\0", 1));
// The maximum legal codepoint, 0x10FFFF.
tt_int_op(1, OP_EQ, string_is_utf8("\xf4\x8f\xbf\xbf", 4));
tt_int_op(0, OP_EQ, string_is_utf8("\xf4\x90\x80\x80", 4));
/* Test cases that vary between programming languages /
* UTF-8 implementations.
* Source: POC||GTFO 19, page 43
​ * https://www.alchemistowl.org/pocorgtfo/
*/
// Invalid (in most implementations)
// surrogate
tt_int_op(0, OP_EQ, string_is_utf8("\xed\xa0\x81", 3));
// nullsurrog
tt_int_op(0, OP_EQ, string_is_utf8("\x30\x00\xed\xa0\x81", 5));
// threehigh
tt_int_op(0, OP_EQ, string_is_utf8("\xed\xbf\xbf", 3));
// fourhigh
tt_int_op(0, OP_EQ, string_is_utf8("\xf4\x90\xbf\xbf", 4));
// fivebyte
tt_int_op(0, OP_EQ, string_is_utf8("\xfb\x80\x80\x80\x80", 5));
// sixbyte
tt_int_op(0, OP_EQ, string_is_utf8("\xfd\x80\x80\x80\x80", 5));
// sixhigh
tt_int_op(0, OP_EQ, string_is_utf8("\xfd\xbf\xbf\xbf\xbf", 5));
// Valid (in most implementations)
// fourbyte
tt_int_op(1, OP_EQ, string_is_utf8("\xf0\x90\x8d\x88", 4));
// fourbyte2
tt_int_op(1, OP_EQ, string_is_utf8("\xf0\xbf\xbf\xbf", 4));
// nullbyte
tt_int_op(1, OP_EQ, string_is_utf8("\x30\x31\x32\x00\x33", 5));
done:
;
}