nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 13:13:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add a paranoia check in string_is_valid_nonrfc_hostname()

Browse Source 
The earlier checks in this function should ensure that components is
always nonempty.  But in case somebody messes with them in the
future, let's add an extra check to make sure we aren't crashing.
This commit is contained in:
Nick Mathewson 2018-03-28 07:48:18 -04:00
parent b504c854d3
commit d4bf1f6c8e
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/common/util.c
View File

@ -1125,6 +1125,9 @@ string_is_valid_nonrfc_hostname(const char *string)
smartlist_split_string(components,string,".",0,0);
if (BUG(smartlist_len(components) == 0))
return 0; // LCOV_EXCL_LINE should be impossible given the earlier checks.
/* Allow a single terminating '.' used rarely to indicate domains
* are FQDNs rather than relative. */
last_label = (char *)smartlist_get(components,