nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

practracker: An exception is "used" even when it is violated.

Browse Source 
The purpose of tracking whether an exception is used is so that we
can tell whether it is overbroad.  This means that an _underbroad_
exception is still a used one.  Fixes bug 31338.
This commit is contained in:
Nick Mathewson 2019-09-18 08:52:01 -04:00
parent 25d55fa01e
commit d1ffac3f8a
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/maint/practracker/problem.py
View File

@ -77,8 +77,10 @@ class ProblemVault(object):
# (e.g. we went from 4k LoC to 3k LoC), but we do warn if the # (e.g. we went from 4k LoC to 3k LoC), but we do warn if the
# situation worsened (e.g. we went from 60 includes to 80). # situation worsened (e.g. we went from 60 includes to 80).
status = problem.is_worse_than(self.exceptions[problem.key()]) status = problem.is_worse_than(self.exceptions[problem.key()])
if status == STATUS_OK:
self.used_exception_for[problem.key()] = problem # Remember that we used this exception, so that we can later
# determine whether the exception was overbroad.
self.used_exception_for[problem.key()] = problem
return status return status