Downgrade "Rejecting RENDEZVOUS1 cell with unrecognized cookie"

This is the loudest of our LOG_PROTOCOL_WARN messages, it can occur
naturally, and there doesn't seem to be a great response to it.

Partial fix for 40400; bugfix on 0.1.1.13-alpha.
This commit is contained in:
Nick Mathewson 2021-10-14 12:21:30 -04:00
parent 0ec08b0643
commit d10ceb7165
2 changed files with 10 additions and 1 deletions

5
changes/bug40400_part2 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (usability):
- Do not log "RENDEZVOUS1 cell with unrecognized rendezvous cookie"
at LOG_PROTOCOL_WARN; instead log it at DEBUG. This warning can happen
naturally if a client gives up on a rendezvous circuit after sending
INTRODUCE1. Fixes part of bug 40400; bugfix on 0.1.1.13-alpha.

View File

@ -131,7 +131,11 @@ rend_mid_rendezvous(or_circuit_t *circ, const uint8_t *request,
rend_circ = hs_circuitmap_get_rend_circ_relay_side(request);
if (!rend_circ) {
log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL,
/* Once this was a LOG_PROTOCOL_WARN, but it can happen naturally if a
* client gives up on a rendezvous circuit after sending INTRODUCE1, but
* before the onion service sends the RENDEZVOUS1 cell.
*/
log_fn(LOG_DEBUG, LD_PROTOCOL,
"Rejecting RENDEZVOUS1 cell with unrecognized rendezvous cookie %s.",
hexid);
reason = END_CIRC_REASON_TORPROTOCOL;