Enable the -Waggregate-return warning

Suppress it in the one spot in the code where we actually do want to
allow an aggregate return in order to call the mallinfo() API.
This commit is contained in:
Nick Mathewson 2016-05-27 11:26:14 -04:00
parent 0df2c5677a
commit ce1dbbc4fd
2 changed files with 3 additions and 2 deletions

View File

@ -1698,8 +1698,7 @@ if test "x$enable_gcc_warnings_advisory" != "xno"; then
CFLAGS="$CFLAGS -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2"
CFLAGS="$CFLAGS -Wwrite-strings -Wmissing-declarations -Wredundant-decls"
CFLAGS="$CFLAGS -Wnested-externs -Wbad-function-cast -Wswitch-enum"
# Disabled, so we can use mallinfo(): -Waggregate-return
CFLAGS="$CFLAGS -Waggregate-return"
if test "x$have_gcc4" = "xyes"; then
# These warnings break gcc 3.3.5 and work on gcc 4.0.2

View File

@ -342,6 +342,7 @@ tor_free_(void *mem)
tor_free(mem);
}
DISABLE_GCC_WARNING(aggregate-return)
/** Call the platform malloc info function, and dump the results to the log at
* level <b>severity</b>. If no such function exists, do nothing. */
void
@ -369,6 +370,7 @@ tor_log_mallinfo(int severity)
);
#endif
}
ENABLE_GCC_WARNING(aggregate-return)
/* =====
* Math