Restore proper behavior of netinfo skew check

My previous fix removed a comparison, which would have caused us to
warn about every skew instead of skews of over an hour.
This commit is contained in:
Nick Mathewson 2019-08-08 09:15:42 -04:00
parent 0849d2a2fd
commit cd6cb45372

View File

@ -1721,7 +1721,7 @@ channel_tls_process_netinfo_cell(cell_t *cell, channel_tls_t *chan)
/* Act on apparent skew. */
/** Warn when we get a netinfo skew with at least this value. */
#define NETINFO_NOTICE_SKEW 3600
if (time_abs(apparent_skew) &&
if (time_abs(apparent_skew) > NETINFO_NOTICE_SKEW &&
router_get_by_id_digest(chan->conn->identity_digest)) {
int trusted = router_digest_is_trusted_dir(chan->conn->identity_digest);
clock_skew_warning(TO_CONN(chan->conn), apparent_skew, trusted, LD_GENERAL,