nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-30 23:53:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

entrynodes: Remove "split these functions" XXXXs

Browse Source 
They now have a ticket: #21349.
This commit is contained in:
Nick Mathewson 2017-01-30 10:49:40 -05:00
parent ed4a3dfef2
commit cccd3f1dae
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/or/entrynodes.c
View File

@ -1157,7 +1157,6 @@ entry_guard_is_listed,(guard_selection_t *gs, const entry_guard_t *guard))
STATIC void STATIC void
sampled_guards_update_from_consensus(guard_selection_t *gs) sampled_guards_update_from_consensus(guard_selection_t *gs)
{ {
/*XXXX prop271 consider splitting this function up. */
tor_assert(gs); tor_assert(gs);
const int REMOVE_UNLISTED_GUARDS_AFTER = const int REMOVE_UNLISTED_GUARDS_AFTER =
(get_remove_unlisted_guards_after_days() * 86400); (get_remove_unlisted_guards_after_days() * 86400);
@ -1581,7 +1580,6 @@ make_guard_confirmed(guard_selection_t *gs, entry_guard_t *guard)
STATIC void STATIC void
entry_guards_update_primary(guard_selection_t *gs) entry_guards_update_primary(guard_selection_t *gs)
{ {
/*XXXX prop271 consider splitting this function up. */
tor_assert(gs); tor_assert(gs);
// prevent recursion. Recursion is potentially very bad here. // prevent recursion. Recursion is potentially very bad here.
@ -1779,7 +1777,6 @@ select_entry_guard_for_circuit(guard_selection_t *gs,
const entry_guard_restriction_t *rst, const entry_guard_restriction_t *rst,
unsigned *state_out) unsigned *state_out)
{ {
/*XXXX prop271 consider splitting this function up. */
tor_assert(gs); tor_assert(gs);
tor_assert(state_out); tor_assert(state_out);