connection: Stop forcing some ports to prefer IPv6

Stop forcing all non-SOCKSPorts to prefer IPv6 exit connections.
Instead, prefer IPv6 connections by default, but allow users to change
their configs using the "NoPreferIPv6" port flag.

Fixes bug 33608; bugfix on 0.4.3.1-alpha.
This commit is contained in:
teor 2020-03-13 12:25:43 +10:00
parent 3e42004e54
commit cc2fb91ea5
No known key found for this signature in database
GPG Key ID: 10FEAA0E7075672A
2 changed files with 7 additions and 1 deletions

5
changes/bug33608 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (client IPv6):
- Stop forcing all non-SOCKSPorts to prefer IPv6 exit connections. Instead,
prefer IPv6 connections by default, but allow users to change their
configs using the "NoPreferIPv6" port flag.
Fixes bug 33608; bugfix on 0.4.3.1-alpha.

View File

@ -1514,10 +1514,11 @@ connection_listener_new(const struct sockaddr *listensockaddr,
}
}
/* Force IPv4 and IPv6 traffic on for non-SOCKSPorts.
* Forcing options on isn't a good idea, see #32994 and #33607. */
if (type != CONN_TYPE_AP_LISTENER) {
lis_conn->entry_cfg.ipv4_traffic = 1;
lis_conn->entry_cfg.ipv6_traffic = 1;
lis_conn->entry_cfg.prefer_ipv6 = 1;
}
if (connection_add(conn) < 0) { /* no space, forget it */