nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Move controller event for socks warning into log_unsafe_socks_warning

Browse Source
This commit is contained in:
Nick Mathewson 2010-11-15 15:41:21 -05:00
parent 522c204ac9
commit cbad9f4520
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/or/buffers.c
View File

@ -1308,7 +1308,8 @@ fetch_from_buf_http(buf_t *buf,
* protocol <b>socks_protocol</b> on port <b>port</b>. Don't warn more than * protocol <b>socks_protocol</b> on port <b>port</b>. Don't warn more than
* once per SOCKS_WARN_INTERVAL, unless <b>safe_socks</b> is set. */ * once per SOCKS_WARN_INTERVAL, unless <b>safe_socks</b> is set. */
static void static void
log_unsafe_socks_warning(int socks_protocol, uint16_t port, int safe_socks) log_unsafe_socks_warning(int socks_protocol, const char *address,
uint16_t port, int safe_socks)
{ {
static ratelim_t socks_ratelim = RATELIM_INIT(SOCKS_WARN_INTERVAL); static ratelim_t socks_ratelim = RATELIM_INIT(SOCKS_WARN_INTERVAL);
@ -1330,6 +1331,9 @@ log_unsafe_socks_warning(int socks_protocol, uint16_t port, int safe_socks)
m ? m : ""); m ? m : "");
tor_free(m); tor_free(m);
} }
control_event_client_status(LOG_WARN,
"DANGEROUS_SOCKS PROTOCOL=SOCKS%d ADDRESS=%s:%d",
socks_protocol, address, (int)port);
} }
/** There is a (possibly incomplete) socks handshake on <b>buf</b>, of one /** There is a (possibly incomplete) socks handshake on <b>buf</b>, of one
@ -1450,10 +1454,7 @@ fetch_from_buf_socks(buf_t *buf, socks_request_t *req,
buf_remove_from_front(buf, 6+addrlen); buf_remove_from_front(buf, 6+addrlen);
if (req->command != SOCKS_COMMAND_RESOLVE_PTR && if (req->command != SOCKS_COMMAND_RESOLVE_PTR &&
!addressmap_have_mapping(req->address,0)) { !addressmap_have_mapping(req->address,0)) {
log_unsafe_socks_warning(5, req->port, safe_socks); log_unsafe_socks_warning(5, req->address, req->port, safe_socks);
control_event_client_status(LOG_WARN,
"DANGEROUS_SOCKS PROTOCOL=SOCKS5 ADDRESS=%s:%d",
req->address, req->port);
if (safe_socks) if (safe_socks)
return -1; return -1;
} }
@ -1554,7 +1555,7 @@ fetch_from_buf_socks(buf_t *buf, socks_request_t *req,
startaddr = NULL; startaddr = NULL;
if (socks4_prot != socks4a && if (socks4_prot != socks4a &&
!addressmap_have_mapping(tmpbuf,0)) { !addressmap_have_mapping(tmpbuf,0)) {
log_unsafe_socks_warning(4, req->port, safe_socks); log_unsafe_socks_warning(4, tmpbuf, req->port, safe_socks);
if (safe_socks) if (safe_socks)
return -1; return -1;