diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ba981d5f14..d2d0d55dd4 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -26,7 +26,7 @@ update: - ssh-add <(echo "$DEPLOY_KEY") # For Docker builds disable host key checking. Be aware that by adding that - # you are suspectible to man-in-the-middle attacks. + # you are susceptible to man-in-the-middle attacks. # WARNING: Use this only with the Docker executor, if you use it with shell # you will overwrite your user's SSH config. - mkdir -p ~/.ssh diff --git a/ChangeLog b/ChangeLog index 96629e37f4..fa1a9e5735 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8267,7 +8267,7 @@ Changes in version 0.2.6.5-rc - 2015-03-18 o Major bugfixes (pluggable transports): - Initialize the extended OR Port authentication cookie before launching pluggable transports. This prevents a race condition - that occured when server-side pluggable transports would cache the + that occurred when server-side pluggable transports would cache the authentication cookie before it has been (re)generated. Fixes bug 15240; bugfix on 0.2.5.1-alpha. @@ -9010,7 +9010,7 @@ Changes in version 0.2.6.2-alpha - 2014-12-31 some bugs where we would look at (but fortunately, not reveal) uninitialized memory on the stack. Fixes bug 14013; bugfix on all versions of Tor. - - Clear all memory targetted by tor_addr_{to,from}_sockaddr(), not + - Clear all memory targeted by tor_addr_{to,from}_sockaddr(), not just the part that's used. This makes it harder for data leak bugs to occur in the event of other programming failures. Resolves ticket 14041. @@ -10153,7 +10153,7 @@ Changes in version 0.2.5.5-alpha - 2014-06-18 directory authority options, remove the documentation for a V2-directory fetching option that no longer exists. Resolves ticket 11634. - - Correct the documenation so that it lists the correct directory + - Correct the documentation so that it lists the correct directory for the stats files. (They are in a subdirectory called "stats", not "status".) - In the manpage, move more authority-only options into the @@ -11438,7 +11438,7 @@ Changes in version 0.2.5.1-alpha - 2013-10-02 from Arlo Breault. - Remove instances of strcpy() from the unit tests. They weren't hurting anything, since they were only in the unit tests, but it's - embarassing to have strcpy() in the code at all, and some analysis + embarrassing to have strcpy() in the code at all, and some analysis tools don't like it. Fixes bug 8790; bugfix on 0.2.3.6-alpha and 0.2.3.8-alpha. Patch from Arlo Breault. @@ -11539,7 +11539,7 @@ Changes in version 0.2.4.16-rc - 2013-08-10 0.2.4.15-rc. Found by stem integration tests. o Minor bugfixes: - - Fix an invalid memory read that occured when a pluggable + - Fix an invalid memory read that occurred when a pluggable transport proxy failed its configuration protocol. Fixes bug 9288; bugfix on 0.2.4.1-alpha. - When evaluating whether to use a connection that we haven't @@ -14330,7 +14330,7 @@ Changes in version 0.2.3.11-alpha - 2012-01-22 CloseHSServiceRendCircuitsImmediatelyOnTimeout option. Fixes the remaining part of bug 1297; bugfix on 0.2.2.2-alpha. - Make sure we never mark the wrong rendezvous circuit as having - had its introduction cell acknowleged by the introduction-point + had its introduction cell acknowledged by the introduction-point relay. Previously, when we received an INTRODUCE_ACK cell on a client-side hidden-service introduction circuit, we might have marked a rendezvous circuit other than the one we specified in @@ -15637,7 +15637,7 @@ Changes in version 0.2.3.3-alpha - 2011-09-01 raised by bug 3898. - The "--quiet" and "--hush" options now apply not only to Tor's behavior before logs are configured, but also to Tor's behavior in - the absense of configured logs. Fixes bug 3550; bugfix on + the absence of configured logs. Fixes bug 3550; bugfix on 0.2.0.10-alpha. o Minor bugfixes (also part of 0.2.2.31-rc): @@ -18138,7 +18138,7 @@ Changes in version 0.2.2.8-alpha - 2010-01-26 please upgrade. o Major bugfixes: - - Fix a memory corruption bug on bridges that occured during the + - Fix a memory corruption bug on bridges that occurred during the inclusion of stats data in extra-info descriptors. Also fix the interface for geoip_get_bridge_stats* to prevent similar bugs in the future. Diagnosis by Tas, patch by Karsten and Sebastian. @@ -18552,7 +18552,7 @@ Changes in version 0.2.2.2-alpha - 2009-09-21 to EDGE and find out if the build-time data in the .tor/state gets reset without loss of Tor usability. You should also see a notice log message telling you that Tor has reset its timeout. - - Directory authorities can now vote on arbitary integer values as + - Directory authorities can now vote on arbitrary integer values as part of the consensus process. This is designed to help set network-wide parameters. Implements proposal 167. - Tor now reads the "circwindow" parameter out of the consensus, @@ -21580,7 +21580,7 @@ Changes in version 0.2.0.9-alpha - 2007-10-24 - Distinguish between detached signatures for the wrong period, and detached signatures for a divergent vote. - Fix a small memory leak when computing a consensus. - - When there's no concensus, we were forming a vote every 30 + - When there's no consensus, we were forming a vote every 30 minutes, but writing the "valid-after" line in our vote based on our configured V3AuthVotingInterval: so unless the intervals matched up, we immediately rejected our own vote because it didn't @@ -24967,7 +24967,7 @@ Changes in version 0.1.0.9-rc - 2005-06-09 KeepalivePeriod, ClientOnly, NoPublish, HttpProxy, HttpsProxy, HttpProxyAuthenticator - Stop warning about sigpipes in the logs. We're going to - pretend that getting these occassionally is normal and fine. + pretend that getting these occasionally is normal and fine. - Resolve OS X installer bugs: stop claiming to be 0.0.9.2 in certain installer screens; and don't put stuff into StartupItems unless @@ -25432,7 +25432,7 @@ Changes in version 0.1.0.1-rc - 2005-03-28 Changes in version 0.0.9.6 - 2005-03-24 o Bugfixes on 0.0.9.x (crashes and asserts): - - Add new end stream reasons to maintainance branch. Fix bug where + - Add new end stream reasons to maintenance branch. Fix bug where reason (8) could trigger an assert. Prevent bug from recurring. - Apparently win32 stat wants paths to not end with a slash. - Fix assert triggers in assert_cpath_layer_ok(), where we were diff --git a/ReleaseNotes b/ReleaseNotes index 65b7c604be..4adba49d78 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -6476,7 +6476,7 @@ Changes in version 0.2.6.6 - 2015-03-24 o Major bugfixes (pluggable transports): - Initialize the extended OR Port authentication cookie before launching pluggable transports. This prevents a race condition - that occured when server-side pluggable transports would cache the + that occurred when server-side pluggable transports would cache the authentication cookie before it has been (re)generated. Fixes bug 15240; bugfix on 0.2.5.1-alpha. @@ -6949,7 +6949,7 @@ Changes in version 0.2.6.6 - 2015-03-24 some bugs where we would look at (but fortunately, not reveal) uninitialized memory on the stack. Fixes bug 14013; bugfix on all versions of Tor. - - Clear all memory targetted by tor_addr_{to,from}_sockaddr(), not + - Clear all memory targeted by tor_addr_{to,from}_sockaddr(), not just the part that's used. This makes it harder for data leak bugs to occur in the event of other programming failures. Resolves ticket 14041. @@ -8126,7 +8126,7 @@ Changes in version 0.2.5.10 - 2014-10-24 from Arlo Breault. - Remove instances of strcpy() from the unit tests. They weren't hurting anything, since they were only in the unit tests, but it's - embarassing to have strcpy() in the code at all, and some analysis + embarrassing to have strcpy() in the code at all, and some analysis tools don't like it. Fixes bug 8790; bugfix on 0.2.3.6-alpha and 0.2.3.8-alpha. Patch from Arlo Breault. - Remove is_internal_IP() function. Resolves ticket 4645. @@ -8150,7 +8150,7 @@ Changes in version 0.2.5.10 - 2014-10-24 directory authority options, remove the documentation for a V2-directory fetching option that no longer exists. Resolves ticket 11634. - - Correct the documenation so that it lists the correct directory + - Correct the documentation so that it lists the correct directory for the stats files. (They are in a subdirectory called "stats", not "status".) - In the manpage, move more authority-only options into the @@ -10293,7 +10293,7 @@ Changes in version 0.2.3.25 - 2012-11-19 bugfix on 0.2.0.3-alpha. - The "--quiet" and "--hush" options now apply not only to Tor's behavior before logs are configured, but also to Tor's behavior in - the absense of configured logs. Fixes bug 3550; bugfix on + the absence of configured logs. Fixes bug 3550; bugfix on 0.2.0.10-alpha. - Change the AllowDotExit rules so they should actually work. We now enforce AllowDotExit only immediately after receiving an @@ -11406,7 +11406,7 @@ Changes in version 0.2.2.32 - 2011-08-27 algorithms for signatures and resource selection. Newer formats are signed with SHA256, with a possibility for moving to a better hash algorithm in the future. - - Directory authorities can now vote on arbitary integer values as + - Directory authorities can now vote on arbitrary integer values as part of the consensus process. This is designed to help set network-wide parameters. Implements proposal 167. @@ -16595,7 +16595,7 @@ Changes in version 0.1.0.10 - 2005-06-14 - Use correct errno on win32 if libevent fails. - Check and warn about known-bad/slow libevent versions. - Stop warning about sigpipes in the logs. We're going to - pretend that getting these occassionally is normal and fine. + pretend that getting these occasionally is normal and fine. o New contrib scripts: - New experimental script tor/contrib/exitlist: a simple python @@ -16714,7 +16714,7 @@ Changes in version 0.0.9.7 - 2005-04-01 Changes in version 0.0.9.6 - 2005-03-24 o Bugfixes on 0.0.9.x (crashes and asserts): - - Add new end stream reasons to maintainance branch. Fix bug where + - Add new end stream reasons to maintenance branch. Fix bug where reason (8) could trigger an assert. Prevent bug from recurring. - Apparently win32 stat wants paths to not end with a slash. - Fix assert triggers in assert_cpath_layer_ok(), where we were diff --git a/configure.ac b/configure.ac index 3cb187b0e9..7eb189a0e9 100644 --- a/configure.ac +++ b/configure.ac @@ -573,7 +573,7 @@ AC_CHECK_FUNCS( # Apple messed up when they added two functions functions in Sierra: they # forgot to decorate them with appropriate AVAILABLE_MAC_OS_VERSION # checks. So we should only probe for those functions if we are sure that we -# are not targetting OSX 10.11 or earlier. +# are not targeting OSX 10.11 or earlier. AC_MSG_CHECKING([for a pre-Sierra OSX build target]) AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ #ifdef __APPLE__ diff --git a/contrib/operator-tools/linux-tor-prio.sh b/contrib/operator-tools/linux-tor-prio.sh index ea9e0ddaa5..30ea5fc659 100644 --- a/contrib/operator-tools/linux-tor-prio.sh +++ b/contrib/operator-tools/linux-tor-prio.sh @@ -87,7 +87,7 @@ RATE_UP=5000 # machine does any other network activity. That is not very fun. RATE_UP_TOR=1500 -# RATE_UP_TOR_CEIL is the maximum rate allowed for all Tor trafic in +# RATE_UP_TOR_CEIL is the maximum rate allowed for all Tor traffic in # kbits/sec. RATE_UP_TOR_CEIL=5000 diff --git a/doc/HACKING/GettingStartedRust.md b/doc/HACKING/GettingStartedRust.md index 3d00388314..3f9cf82ea7 100644 --- a/doc/HACKING/GettingStartedRust.md +++ b/doc/HACKING/GettingStartedRust.md @@ -117,7 +117,7 @@ the module calls. Modules which call fewer other modules are better targets. Strive to change the C API as little as possible. -We are currently targetting Rust nightly, *for now*. We expect this to change +We are currently targeting Rust nightly, *for now*. We expect this to change moving forward, as we understand more about which nightly features we need. It is on our TODO list to try to cultivate good standing with various distro maintainers of `rustc` and `cargo`, in order to ensure that whatever version we diff --git a/doc/HACKING/Tracing.md b/doc/HACKING/Tracing.md index a5fb5165e2..349aade23a 100644 --- a/doc/HACKING/Tracing.md +++ b/doc/HACKING/Tracing.md @@ -6,7 +6,7 @@ tracing framework. ## Basics ### -Event tracing is seperated in two concepts, trace events and a tracer. The +Event tracing is separated in two concepts, trace events and a tracer. The tracing subsystem can be found in `src/trace`. The `events.h` header file is the main file that maps the different tracers to trace events. diff --git a/doc/HACKING/android/Simpleperf.md b/doc/HACKING/android/Simpleperf.md index c12558aed4..25f39a3d23 100644 --- a/doc/HACKING/android/Simpleperf.md +++ b/doc/HACKING/android/Simpleperf.md @@ -18,7 +18,7 @@ the Android Software Development Kit (SDK) and Native Development Kit repository and build an Orbot APK (Android Package) file with debugging enabled. Make sure that when you build the native content of the Orbot application that you run the `make -C external` command with - an additional `DEBUG=1` as paramter to ensure that the Orbot build + an additional `DEBUG=1` as parameter to ensure that the Orbot build process does not strip the debug symbols from the Tor binary. 2. (Optional) Uninstall and clean-up your old Orbot installation that diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 5ad8183650..9a4e70c769 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -2695,7 +2695,7 @@ The following options are used to configure a hidden service. [[HiddenServiceMaxStreams]] **HiddenServiceMaxStreams** __N__:: The maximum number of simultaneous streams (connections) per rendezvous circuit. The maximum value allowed is 65535. (Setting this to 0 will allow - an unlimited number of simultanous streams.) (Default: 0) + an unlimited number of simultaneous streams.) (Default: 0) [[HiddenServiceMaxStreamsCloseCircuit]] **HiddenServiceMaxStreamsCloseCircuit** **0**|**1**:: If set to 1, then exceeding **HiddenServiceMaxStreams** will cause the @@ -3186,7 +3186,7 @@ __CacheDirectory__**/diff-cache**:: Directory cache only. Holds older consensuses, and diffs from older consensuses to the most recent consensus of each type, compressed in various ways. Each file contains a set of key-value arguments - decribing its contents, followed by a single NUL byte, followed by the + describing its contents, followed by a single NUL byte, followed by the main file contents. __DataDirectory__**/bw_accounting**:: diff --git a/scripts/maint/redox.py b/scripts/maint/redox.py index 12aed6463a..53d3d902eb 100755 --- a/scripts/maint/redox.py +++ b/scripts/maint/redox.py @@ -101,7 +101,7 @@ def read(): def findline(lines, lineno, ident): """Given a list of all the lines in the file (adjusted so 1-indexing works), - a line number that ident is alledgedly on, and ident, I figure out + a line number that ident is allegedly on, and ident, I figure out the line where ident was really declared.""" lno = lineno for lineno in xrange(lineno, 0, -1): diff --git a/scripts/maint/updateFallbackDirs.py b/scripts/maint/updateFallbackDirs.py index dbd15eb519..c854830e18 100755 --- a/scripts/maint/updateFallbackDirs.py +++ b/scripts/maint/updateFallbackDirs.py @@ -232,7 +232,7 @@ MAX_FALLBACKS_PER_FAMILY = 7 ## Fallback Bandwidth Requirements -# Any fallback with the Exit flag has its bandwidth multipled by this fraction +# Any fallback with the Exit flag has its bandwidth multiplied by this fraction # to make sure we aren't further overloading exits # (Set to 1.0, because we asked that only lightly loaded exits opt-in, # and the extra load really isn't that much for large relays.) @@ -561,7 +561,7 @@ class Candidate(object): details['flags'] = [] if (not 'advertised_bandwidth' in details or details['advertised_bandwidth'] is None): - # relays without advertised bandwdith have it calculated from their + # relays without advertised bandwidth have it calculated from their # consensus weight details['advertised_bandwidth'] = 0 if (not 'effective_family' in details @@ -1595,7 +1595,7 @@ class CandidateList(dict): excluded_count, initial_count) # calculate each fallback's measured bandwidth based on the median - # consensus weight to advertised bandwdith ratio + # consensus weight to advertised bandwidth ratio def calculate_measured_bandwidth(self): self.sort_fallbacks_by_cw_to_bw_factor() median_fallback = self.fallback_median(True) diff --git a/src/common/address.c b/src/common/address.c index d96ec514b1..7ff81206e5 100644 --- a/src/common/address.c +++ b/src/common/address.c @@ -1125,7 +1125,7 @@ tor_addr_compare_masked(const tor_addr_t *addr1, const tor_addr_t *addr2, case AF_UNIX: /* HACKHACKHACKHACKHACK: * tor_addr_t doesn't contain a copy of sun_path, so it's not - * possible to comapre this at all. + * possible to compare this at all. * * Since the only time we currently actually should be comparing * 2 AF_UNIX addresses is when dealing with ISO_CLIENTADDR (which diff --git a/src/common/compat.c b/src/common/compat.c index 6a61c6c919..39d2f18f4a 100644 --- a/src/common/compat.c +++ b/src/common/compat.c @@ -2455,7 +2455,7 @@ get_environment(void) /** Get name of current host and write it to name array, whose * length is specified by namelen argument. Return 0 upon - * successfull completion; otherwise return return -1. (Currently, + * successful completion; otherwise return return -1. (Currently, * this function is merely a mockable wrapper for POSIX gethostname().) */ MOCK_IMPL(int, diff --git a/src/common/compat_openssl.h b/src/common/compat_openssl.h index d1b871b0f1..1299ac36bb 100644 --- a/src/common/compat_openssl.h +++ b/src/common/compat_openssl.h @@ -12,7 +12,7 @@ /** * \file compat_openssl.h * - * \brief compatability definitions for working with different openssl forks + * \brief compatibility definitions for working with different openssl forks **/ #if !defined(LIBRESSL_VERSION_NUMBER) && \ diff --git a/src/common/compat_time.c b/src/common/compat_time.c index 8cecff2783..183a60a480 100644 --- a/src/common/compat_time.c +++ b/src/common/compat_time.c @@ -807,7 +807,7 @@ monotime_coarse_absolute_msec(void) return monotime_coarse_absolute_nsec() / ONE_MILLION; } #else -#define initalized_at_coarse initialized_at +#define initialized_at_coarse initialized_at #endif /* defined(MONOTIME_COARSE_FN_IS_DIFFERENT) */ /** diff --git a/src/common/crypto.c b/src/common/crypto.c index 2ecf64c393..6e420ab051 100644 --- a/src/common/crypto.c +++ b/src/common/crypto.c @@ -1917,7 +1917,7 @@ crypto_strongest_rand_syscall(uint8_t *out, size_t out_len) #elif defined(__linux__) && defined(SYS_getrandom) static int getrandom_works = 1; /* Be optimitic about our chances... */ - /* getrandom() isn't as straight foward as getentropy(), and has + /* getrandom() isn't as straightforward as getentropy(), and has * no glibc wrapper. * * As far as I can tell from getrandom(2) and the source code, the @@ -1930,7 +1930,7 @@ crypto_strongest_rand_syscall(uint8_t *out, size_t out_len) * * We optimistically assume that getrandom() is available and functional * because it is the way of the future, and 2 branch mispredicts pale in - * comparision to the overheads involved with failing to open + * comparison to the overheads involved with failing to open * /dev/srandom followed by opening and reading from /dev/urandom. */ if (PREDICT_LIKELY(getrandom_works)) { diff --git a/src/common/crypto_ed25519.c b/src/common/crypto_ed25519.c index 26523e3126..a5a61cba1c 100644 --- a/src/common/crypto_ed25519.c +++ b/src/common/crypto_ed25519.c @@ -225,7 +225,7 @@ ed25519_public_key_is_zero(const ed25519_public_key_t *pubkey) /* Return a heap-allocated array that contains msg prefixed by the * string prefix_str. Set final_msg_len_out to the size of the - * final array. If an error occured, return NULL. It's the resonsibility of the + * final array. If an error occurred, return NULL. It's the resonsibility of the * caller to free the returned array. */ static uint8_t * get_prefixed_msg(const uint8_t *msg, size_t msg_len, @@ -259,7 +259,7 @@ get_prefixed_msg(const uint8_t *msg, size_t msg_len, * Set signature_out to a signature of the len-byte message * msg, using the secret and public key in keypair. * - * Return 0 if we successfuly signed the message, otherwise return -1. + * Return 0 if we successfully signed the message, otherwise return -1. */ int ed25519_sign(ed25519_signature_t *signature_out, @@ -529,7 +529,7 @@ ed25519_keypair_blind(ed25519_keypair_t *out, /** * Given an ed25519 public key in inp, generate a corresponding blinded * public key in out, blinded with the 32-byte parameter in - * param. Return 0 on sucess, -1 on railure. + * param. Return 0 on success, -1 on railure. */ int ed25519_public_blind(ed25519_public_key_t *out, @@ -719,7 +719,7 @@ ed25519_impl_spot_check,(void)) return -1; /* XXX/yawning: Someone that's more paranoid than I am, can write "Assume - * ref0 is cannonical, and fuzz impl against it" if they want, but I doubt + * ref0 is canonical, and fuzz impl against it" if they want, but I doubt * that will catch anything that the known answer tests won't. */ goto end; @@ -762,7 +762,7 @@ pick_ed25519_impl(void) /* LCOV_EXCL_STOP */ } -/* Initialize the Ed25519 implementation. This is neccessary if you're +/* Initialize the Ed25519 implementation. This is necessary if you're * going to use them in a multithreaded setting, and not otherwise. */ void ed25519_init(void) diff --git a/src/common/crypto_rsa.c b/src/common/crypto_rsa.c index 92b5978eaf..fa572580a4 100644 --- a/src/common/crypto_rsa.c +++ b/src/common/crypto_rsa.c @@ -852,7 +852,7 @@ crypto_pk_get_hashed_fingerprint(crypto_pk_t *pk, char *fp_out) /** Given a crypto_pk_t pk, allocate a new buffer containing the * Base64 encoding of the DER representation of the private key as a NUL * terminated string, and return it via priv_out. Return 0 on - * sucess, -1 on failure. + * success, -1 on failure. * * It is the caller's responsibility to sanitize and free the resulting buffer. */ diff --git a/src/common/timers.c b/src/common/timers.c index 93cde7de5f..552080b11e 100644 --- a/src/common/timers.c +++ b/src/common/timers.c @@ -63,7 +63,7 @@ struct timeout_cb { #define TIMEOUT_CB_OVERRIDE /* We're going to support timers that are pretty far out in advance. Making * this big can be inefficient, but having a significant number of timers - * above TIMEOUT_MAX can also be super-inefficent. Choosing 5 here sets + * above TIMEOUT_MAX can also be super-inefficient. Choosing 5 here sets * timeout_max to 2^30 ticks, or 29 hours with our value for USEC_PER_TICK */ #define WHEEL_NUM 5 #include "src/ext/timeouts/timeout.c" diff --git a/src/common/tortls.c b/src/common/tortls.c index 86a876780a..bff59833ff 100644 --- a/src/common/tortls.c +++ b/src/common/tortls.c @@ -1942,7 +1942,7 @@ tor_tls_handshake(tor_tls_t *tls) return r; } -/** Perform the final part of the intial TLS handshake on tls. This +/** Perform the final part of the initial TLS handshake on tls. This * should be called for the first handshake only: it determines whether the v1 * or the v2 handshake was used, and adjusts things for the renegotiation * handshake as appropriate. diff --git a/src/common/util.c b/src/common/util.c index 67e97811c6..90204befc0 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -3047,7 +3047,7 @@ unescape_string(const char *s, char **result, size_t *size_out) /** Removes enclosing quotes from path and unescapes quotes between the * enclosing quotes. Backslashes are not unescaped. Return the unquoted - * path on sucess or 0 if path is not quoted correctly. */ + * path on success or 0 if path is not quoted correctly. */ char * get_unquoted_path(const char *path) { @@ -3898,7 +3898,7 @@ format_number_sigsafe(unsigned long x, char *buf, int buf_len, * call it with a signed int and an unsigned char, and since the C standard * does not guarantee that an int is wider than a char (an int must be at * least 16 bits but it is permitted for a char to be that wide as well), we - * can't assume a signed int is sufficient to accomodate an unsigned char. + * can't assume a signed int is sufficient to accommodate an unsigned char. * Thus, format_helper_exit_status() will still need to emit any require '-' * on its own. * @@ -3928,7 +3928,7 @@ format_dec_number_sigsafe(unsigned long x, char *buf, int buf_len) * * The format of hex_errno is: "CHILD_STATE/ERRNO\n", left-padded * with spaces. CHILD_STATE indicates where - * in the processs of starting the child process did the failure occur (see + * in the process of starting the child process did the failure occur (see * CHILD_STATE_* macros for definition), and SAVED_ERRNO is the value of * errno when the failure occurred. * diff --git a/src/ext/ed25519/donna/ed25519_tor.c b/src/ext/ed25519/donna/ed25519_tor.c index 44ec562f02..84fc3850a2 100644 --- a/src/ext/ed25519/donna/ed25519_tor.c +++ b/src/ext/ed25519/donna/ed25519_tor.c @@ -132,7 +132,7 @@ ED25519_FN(curved25519_scalarmult_basepoint) (curved25519_key pk, const curved25 } /* - Tor has a specific idea of how an Ed25519 implementaion should behave. + Tor has a specific idea of how an Ed25519 implementation should behave. Implement such a beast using the ed25519-donna primitives/internals. * Private key generation using Tor's CSPRNG. diff --git a/src/or/bridges.c b/src/or/bridges.c index 383c33fa61..d88d6c6434 100644 --- a/src/or/bridges.c +++ b/src/or/bridges.c @@ -356,7 +356,7 @@ bridge_resolve_conflicts(const tor_addr_t *addr, uint16_t port, { /* Iterate the already-registered bridge list: - If you find a bridge with the same adress and port, mark it for + If you find a bridge with the same address and port, mark it for removal. It doesn't make sense to have two active bridges with the same IP:PORT. If the bridge in question has a different digest or transport than digest/transport_name, diff --git a/src/or/channel.c b/src/or/channel.c index 1afd451908..e5cdf9bc7c 100644 --- a/src/or/channel.c +++ b/src/or/channel.c @@ -31,7 +31,7 @@ * channel_set_cell_handlers(). Currently, this is passed back to the command * subsystem which is command_process_cell(). * - * NOTE: For now, the seperation between channels and specialized channels + * NOTE: For now, the separation between channels and specialized channels * (like channeltls) is not that well defined. So the channeltls layer calls * channel_process_cell() which originally comes from the connection subsytem. * This should be hopefully be fixed with #23993. @@ -1438,7 +1438,7 @@ channel_clear_remote_end(channel_t *chan) * * Two possible errors can happen. Either the channel is not opened or the * lower layer (specialized channel) failed to write it. In both cases, it is - * the caller responsability to free the cell. + * the caller responsibility to free the cell. */ static int write_packed_cell(channel_t *chan, packed_cell_t *cell) @@ -1514,7 +1514,7 @@ channel_write_packed_cell(channel_t *chan, packed_cell_t *cell) ret = write_packed_cell(chan, cell); end: - /* Whatever happens, we free the cell. Either an error occured or the cell + /* Whatever happens, we free the cell. Either an error occurred or the cell * was put on the connection outbuf, both cases we have ownership of the * cell and we free it. */ packed_cell_free(cell); @@ -1717,7 +1717,7 @@ channel_listener_change_state(channel_listener_t *chan_l, } } -/* Maximum number of cells that is allowed to flush at once withing +/* Maximum number of cells that is allowed to flush at once within * channel_flush_some_cells(). */ #define MAX_CELLS_TO_GET_FROM_CIRCUITS_FOR_UNLIMITED 256 diff --git a/src/or/circpathbias.c b/src/or/circpathbias.c index f4bd5ea2fa..c1c1ca31be 100644 --- a/src/or/circpathbias.c +++ b/src/or/circpathbias.c @@ -1467,7 +1467,7 @@ pathbias_measure_close_rate(entry_guard_t *guard) * * XXX: The attempt count transfer stuff here might be done * better by keeping separate pending counters that get - * transfered at circuit close. See ticket #8160. + * transferred at circuit close. See ticket #8160. */ static void pathbias_scale_close_rates(entry_guard_t *guard) @@ -1527,7 +1527,7 @@ pathbias_scale_close_rates(entry_guard_t *guard) * * XXX: The attempt count transfer stuff here might be done * better by keeping separate pending counters that get - * transfered at circuit close. See ticket #8160. + * transferred at circuit close. See ticket #8160. */ void pathbias_scale_use_rates(entry_guard_t *guard) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 9c049a24b3..3bbcc5144c 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -2223,7 +2223,7 @@ pick_restricted_middle_node(router_crn_flags_t flags, * Max number of restricted nodes before we alert the user and try * to load balance for them. * - * The most agressive vanguard design had 16 nodes at layer3. + * The most aggressive vanguard design had 16 nodes at layer3. * Let's give a small ceiling above that. */ #define MAX_SANE_RESTRICTED_NODES 20 /* If the user (or associated tor controller) selected only a few nodes, diff --git a/src/or/circuitlist.c b/src/or/circuitlist.c index 8c02cd1c19..e134b157cc 100644 --- a/src/or/circuitlist.c +++ b/src/or/circuitlist.c @@ -806,9 +806,9 @@ circuit_purpose_to_string(uint8_t purpose) case CIRCUIT_PURPOSE_INTRO_POINT: return "Acting as intro point"; case CIRCUIT_PURPOSE_REND_POINT_WAITING: - return "Acting as rendevous (pending)"; + return "Acting as rendezvous (pending)"; case CIRCUIT_PURPOSE_REND_ESTABLISHED: - return "Acting as rendevous (established)"; + return "Acting as rendezvous (established)"; case CIRCUIT_PURPOSE_C_GENERAL: return "General-purpose client"; case CIRCUIT_PURPOSE_C_INTRODUCING: diff --git a/src/or/circuitstats.c b/src/or/circuitstats.c index f1df19eb25..6438319273 100644 --- a/src/or/circuitstats.c +++ b/src/or/circuitstats.c @@ -167,7 +167,7 @@ circuit_build_times_disabled_(const or_options_t *options, } /** - * Retrieve and bounds-check the cbtmaxtimeouts consensus paramter. + * Retrieve and bounds-check the cbtmaxtimeouts consensus parameter. * * Effect: When this many timeouts happen in the last 'cbtrecentcount' * circuit attempts, the client should discard all of its history and @@ -194,7 +194,7 @@ circuit_build_times_max_timeouts(void) } /** - * Retrieve and bounds-check the cbtnummodes consensus paramter. + * Retrieve and bounds-check the cbtnummodes consensus parameter. * * Effect: This value governs how many modes to use in the weighted * average calculation of Pareto parameter Xm. A value of 3 introduces @@ -221,7 +221,7 @@ circuit_build_times_default_num_xm_modes(void) } /** - * Retrieve and bounds-check the cbtmincircs consensus paramter. + * Retrieve and bounds-check the cbtmincircs consensus parameter. * * Effect: This is the minimum number of circuits to build before * computing a timeout. @@ -253,7 +253,7 @@ circuit_build_times_enough_to_compute(const circuit_build_times_t *cbt) } /** - * Retrieve and bounds-check the cbtquantile consensus paramter. + * Retrieve and bounds-check the cbtquantile consensus parameter. * * Effect: This is the position on the quantile curve to use to set the * timeout value. It is a percent (10-99). @@ -277,7 +277,7 @@ circuit_build_times_quantile_cutoff(void) } /** - * Retrieve and bounds-check the cbtclosequantile consensus paramter. + * Retrieve and bounds-check the cbtclosequantile consensus parameter. * * Effect: This is the position on the quantile curve to use to set the * timeout value to use to actually close circuits. It is a percent @@ -309,7 +309,7 @@ circuit_build_times_close_quantile(void) } /** - * Retrieve and bounds-check the cbttestfreq consensus paramter. + * Retrieve and bounds-check the cbttestfreq consensus parameter. * * Effect: Describes how often in seconds to build a test circuit to * gather timeout values. Only applies if less than 'cbtmincircs' @@ -356,7 +356,7 @@ circuit_build_times_min_timeout(void) } /** - * Retrieve and bounds-check the cbtinitialtimeout consensus paramter. + * Retrieve and bounds-check the cbtinitialtimeout consensus parameter. * * Effect: This is the timeout value to use before computing a timeout, * in milliseconds. @@ -386,7 +386,7 @@ circuit_build_times_initial_timeout(void) } /** - * Retrieve and bounds-check the cbtrecentcount consensus paramter. + * Retrieve and bounds-check the cbtrecentcount consensus parameter. * * Effect: This is the number of circuit build times to keep track of * for deciding if we hit cbtmaxtimeouts and need to reset our state diff --git a/src/or/circuituse.c b/src/or/circuituse.c index 700aa92ac7..1ac950a3c3 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -674,7 +674,7 @@ circuit_expire_building(void) break; case CIRCUIT_PURPOSE_C_INTRODUCING: /* That purpose means that the intro point circuit has been opened - * succesfully but the INTRODUCE1 cell hasn't been sent yet because + * successfully but the INTRODUCE1 cell hasn't been sent yet because * the client is waiting for the rendezvous point circuit to open. * Keep this circuit open while waiting for the rendezvous circuit. * We let the circuit idle timeout take care of cleaning this diff --git a/src/or/config.c b/src/or/config.c index e525624acf..c246bd00e1 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -3146,7 +3146,7 @@ warn_if_option_path_is_relative(const char *option, return 0; } -/** Scan options for occurances of relative file/directory +/** Scan options for occurrences of relative file/directory * path and log a warning whenever it is found. * * Return 1 if there were relative paths; 0 otherwise. diff --git a/src/or/connection.c b/src/or/connection.c index 5bbb61dfa9..fb87e5b05f 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -4250,7 +4250,7 @@ connection_buf_add_buf(connection_t *conn, buf_t *buf) /* Return a list of connections that aren't close and matches the given type * and state. The returned list can be empty and must be freed using - * smartlist_free(). The caller does NOT have owernship of the objects in the + * smartlist_free(). The caller does NOT have ownership of the objects in the * list so it must not free them nor reference them as they can disappear. */ smartlist_t * connection_list_by_type_state(int type, int state) @@ -4260,7 +4260,7 @@ connection_list_by_type_state(int type, int state) /* Return a list of connections that aren't close and matches the given type * and purpose. The returned list can be empty and must be freed using - * smartlist_free(). The caller does NOT have owernship of the objects in the + * smartlist_free(). The caller does NOT have ownership of the objects in the * list so it must not free them nor reference them as they can disappear. */ smartlist_t * connection_list_by_type_purpose(int type, int purpose) diff --git a/src/or/control.c b/src/or/control.c index cce5c7953b..948ac92bb1 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -4458,11 +4458,11 @@ handle_control_hspost(control_connection_t *conn, * used in pk is given to the HS subsystem so the caller must stop accessing * it after. * - * The port_cfgs is a list of service port. Ownership transfered to service. + * The port_cfgs is a list of service port. Ownership transferred to service. * The max_streams refers to the MaxStreams= key. * The max_streams_close_circuit refers to the MaxStreamsCloseCircuit key. * The auth_type is the authentication type of the clients in auth_clients. - * The ownership of that list is transfered to the service. + * The ownership of that list is transferred to the service. * * On success (RSAE_OKAY), the address_out points to a newly allocated string * containing the onion address without the .onion part. On error, address_out @@ -4911,7 +4911,7 @@ add_onion_helper_keyarg(const char *arg, int discard_pk, goto err; } - /* Succeded in loading or generating a private key. */ + /* Succeeded in loading or generating a private key. */ ret = 0; err: diff --git a/src/or/directory.c b/src/or/directory.c index c55f81bc62..983a3e2f34 100644 --- a/src/or/directory.c +++ b/src/or/directory.c @@ -1112,7 +1112,7 @@ directory_request_free_(directory_request_t *req) /** * Set the address and OR port to use for this directory request. If there is * no OR port, we'll have to connect over the dirport. (If there are both, - * the indirection setting determins which to use.) + * the indirection setting determines which to use.) */ void directory_request_set_or_addr_port(directory_request_t *req, @@ -1123,7 +1123,7 @@ directory_request_set_or_addr_port(directory_request_t *req, /** * Set the address and dirport to use for this directory request. If there * is no dirport, we'll have to connect over the OR port. (If there are both, - * the indirection setting determins which to use.) + * the indirection setting determines which to use.) */ void directory_request_set_dir_addr_port(directory_request_t *req, @@ -3413,7 +3413,7 @@ connection_dir_process_inbuf(dir_connection_t *conn) } /** We are closing a dir connection: If dir_conn is a dir connection - * that tried to fetch an HS descriptor, check if it successfuly fetched it, + * that tried to fetch an HS descriptor, check if it successfully fetched it, * or if we need to try again. */ static void refetch_hsdesc_if_needed(dir_connection_t *dir_conn) @@ -4036,7 +4036,7 @@ find_best_diff(const smartlist_t *digests, int flav, } /** Lookup the cached consensus document by the flavor found in flav. - * The prefered set of compression methods should be listed in the + * The preferred set of compression methods should be listed in the * compression_methods bitfield. The compression method chosen (if any) * is stored in compression_used_out. */ static struct consensus_cache_entry_t * @@ -4948,7 +4948,7 @@ handle_get_robots(dir_connection_t *conn, const get_handler_args_t *args) /* Given the url from a POST request, try to extract the version number * using the provided prefix. The version should be after the prefix and - * ending with the seperator "/". For instance: + * ending with the separator "/". For instance: * /tor/hs/3/publish * * On success, end_pos points to the position right after the version diff --git a/src/or/dirserv.c b/src/or/dirserv.c index d3bae241f9..fc6358a72a 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -43,7 +43,7 @@ * the directory authority functionality. The directory.c module delegates * here in order to handle incoming requests from clients, via * connection_dirserv_flushed_some() and its kin. In order to save RAM, this - * module is reponsible for spooling directory objects (in whole or in part) + * module is responsible for spooling directory objects (in whole or in part) * onto buf_t instances, and then closing the dir_connection_t once the * objects are totally flushed. * @@ -1086,7 +1086,7 @@ router_is_active(const routerinfo_t *ri, const node_t *node, time_t now) if (!node->is_running || !node->is_valid || ri->is_hibernating) { return 0; } - /* Only require bandwith capacity in non-test networks, or + /* Only require bandwidth capacity in non-test networks, or * if TestingTorNetwork, and TestingMinExitFlagThreshold is non-zero */ if (!ri->bandwidthcapacity) { if (get_options()->TestingTorNetwork) { diff --git a/src/or/dirserv.h b/src/or/dirserv.h index 0fd7b79150..b9af68ff6e 100644 --- a/src/or/dirserv.h +++ b/src/or/dirserv.h @@ -123,7 +123,7 @@ void dirserv_set_cached_consensus_networkstatus(const char *consensus, void dirserv_clear_old_networkstatuses(time_t cutoff); int dirserv_get_routerdesc_spool(smartlist_t *spools_out, const char *key, dir_spool_source_t source, - int conn_is_encrytped, + int conn_is_encrypted, const char **msg_out); int dirserv_get_routerdescs(smartlist_t *descs_out, const char *key, const char **msg); diff --git a/src/or/dirvote.c b/src/or/dirvote.c index 465c4148bc..c3cd0d3cd1 100644 --- a/src/or/dirvote.c +++ b/src/or/dirvote.c @@ -665,7 +665,7 @@ static int consensus_method_is_supported(int method) { if (method == MIN_METHOD_FOR_ED25519_ID_IN_MD) { - /* This method was broken due to buggy code accidently left in + /* This method was broken due to buggy code accidentally left in * dircollate.c; do not actually use it. */ return 0; diff --git a/src/or/dns.c b/src/or/dns.c index 1f00fe5b4d..e4dc8048ed 100644 --- a/src/or/dns.c +++ b/src/or/dns.c @@ -19,7 +19,7 @@ * dns_seems_to_be_broken(). *