Make dump_desc() use binary mode

Otherwise, it could mung the thing that came over the net on windows,
which would defeat the purpose of recording the unparseable thing.

Fixes bug 11342; bugfix on 0.2.2.1-alpha.
This commit is contained in:
Nick Mathewson 2014-03-27 23:53:03 -04:00
parent a83abcf5ee
commit bfe783f167
2 changed files with 5 additions and 1 deletions

4
changes/bug11342 Normal file
View File

@ -0,0 +1,4 @@
o Minor bugfixes:
- When dumping a malformed directory object to disk, save it in binary
mode on windows, not text mode. Fixes bug 11342; bugfix on
0.2.2.1-alpha.

View File

@ -598,7 +598,7 @@ dump_desc(const char *desc, const char *type)
char *content = tor_malloc_zero(filelen);
tor_snprintf(content, filelen, "Unable to parse descriptor of type "
"%s:\n%s", type, desc);
write_str_to_file(debugfile, content, 0);
write_str_to_file(debugfile, content, 1);
log_info(LD_DIR, "Unable to parse descriptor of type %s. See file "
"unparseable-desc in data directory for details.", type);
tor_free(content);