nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 14:23:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Note a bug that causes servers to sometimes never send the pending

Browse Source 
create cell. Nick, is this a bug? If so, is my fix right?


svn:r6538
This commit is contained in:
Roger Dingledine 2006-06-05 07:27:48 +00:00
parent 266afcd7d5
commit bf09898f79
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/or/circuitbuild.c
View File

@ -449,6 +449,14 @@ circuit_n_conn_done(connection_t *or_conn, int status)
} }
tor_free(circ->onionskin); tor_free(circ->onionskin);
circuit_set_state(circ, CIRCUIT_STATE_OPEN); circuit_set_state(circ, CIRCUIT_STATE_OPEN);
/* XXX: Since circuit_set_state removes circ from the
* circuits_pending_or_conns, we will skip over whatever
* the next entry is when we proceed with the SMARTLIST_FOREACH.
* Thus if there's ever more than one entry, we will miss some.
*
* Is this true? If so, is the fix to decrement circ_sl_idx
* here too? -RD
*/
} }
} }
}); });