nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-23 20:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

circuit: Remove log_warn triggered by a proto violation

Browse Source 
Fixes #40932

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2024-04-16 11:05:52 -04:00
parent 29e3601c42
commit bedc6a90d2
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changes/ticket40932 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfix (circuit):
- Remove a log_warn being triggered by a protocol violation that already
emits a protocol warning log. Fixes bug 40932; bugfix on 0.4.8.1-alpha.

1
src/core/or/relay.c
View File

@ -751,7 +751,6 @@ relay_send_command_from_edge_,(streamid_t stream_id, circuit_t *orig_circ,
cpath_layer, stream_id, filename, cpath_layer, stream_id, filename,
lineno); lineno);
if (ret < 0) { if (ret < 0) {
log_warn(LD_BUG,"circuit_package_relay_cell failed. Closing.");
circuit_mark_for_close(circ, END_CIRC_REASON_INTERNAL); circuit_mark_for_close(circ, END_CIRC_REASON_INTERNAL);
return -1; return -1;
} else if (ret == 0) { } else if (ret == 0) {

1
src/feature/hs/hs_intropoint.c
View File

@ -710,7 +710,6 @@ handle_introduce1(or_circuit_t *client_circ, const uint8_t *request,
RELAY_COMMAND_INTRODUCE2, RELAY_COMMAND_INTRODUCE2,
(char *) request, request_len, NULL)) { (char *) request, request_len, NULL)) {
relay_increment_intro1_action(INTRO1_CIRCUIT_DEAD); relay_increment_intro1_action(INTRO1_CIRCUIT_DEAD);
log_warn(LD_PROTOCOL, "Unable to send INTRODUCE2 cell to the service.");
/* Inform the client that we can't relay the cell. Use the unknown ID /* Inform the client that we can't relay the cell. Use the unknown ID
* status code since it means that we do not know the service. */ * status code since it means that we do not know the service. */
status = TRUNNEL_HS_INTRO_ACK_STATUS_UNKNOWN_ID; status = TRUNNEL_HS_INTRO_ACK_STATUS_UNKNOWN_ID;