nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 14:23:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix a pair of stale comments in workqueue.c

Browse Source 
These comments said that each thread had a separate queue, but we
haven't been using that design for some while.
This commit is contained in:
Nick Mathewson 2017-07-12 11:52:13 -04:00
parent efadebf7c3
commit bddea78ded
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/common/workqueue.c
View File

@ -113,9 +113,7 @@ struct replyqueue_s {
alert_sockets_t alert; alert_sockets_t alert;
}; };
/** A worker thread represents a single thread in a thread pool. To avoid /** A worker thread represents a single thread in a thread pool. */
* contention, each gets its own queue. This breaks the guarantee that that
* queued work will get executed strictly in order. */
typedef struct workerthread_s { typedef struct workerthread_s {
/** Which thread it this? In range 0..in_pool->n_threads-1 */ /** Which thread it this? In range 0..in_pool->n_threads-1 */
int index; int index;
@ -368,7 +366,7 @@ workerthread_new(int32_t lower_priority_chance,
* take from the queued work with the highest prioirity, but will occasionally * take from the queued work with the highest prioirity, but will occasionally
* visit lower-priority queues to keep them from starving completely. * visit lower-priority queues to keep them from starving completely.
* *
* Note that because each thread has its own work queue, work items may not * Note that because of priorities and thread behavior, work items may not
* be executed strictly in order. * be executed strictly in order.
*/ */
workqueue_entry_t * workqueue_entry_t *