Having a ControlPort open doesn't mean we are a client

The any_client_port_set() returns true if the ControlPort is set which is
wrong because we can have that port open but still not behave as a tor client
(like many relays for instance).

Fixes #26062

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2018-05-09 12:40:06 -04:00
parent 5227754b2f
commit bca8a104b2
2 changed files with 3 additions and 1 deletions

3
changes/ticket26062 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (client):
- Don't consider Tor running as a client if the ControlPort is open. Fixes
bug 26062; bugfix on 0.2.9.4-alpha.

View File

@ -1584,7 +1584,6 @@ any_client_port_set(const or_options_t *options)
return (options->SocksPort_set || return (options->SocksPort_set ||
options->TransPort_set || options->TransPort_set ||
options->NATDPort_set || options->NATDPort_set ||
options->ControlPort_set ||
options->DNSPort_set); options->DNSPort_set);
} }