nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-30 23:53:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Pathbias should continue to ignore previously ignored circs.

Browse Source 
If circuit padding wants to keep a circuit open and pathbias used to ignore
it, pathbias should continue to ignore it.

This may catch other purpose-change related miscounts (such as timeout
measurement, cannibalization, onion service circuit transitions, and
vanguards).
This commit is contained in:
Mike Perry 2019-05-08 21:21:03 +00:00 committed by George Kadianakis
parent 5cc988a947
commit b98bcd789e
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/feature/client/circpathbias.c
View File

@ -400,12 +400,13 @@ pathbias_should_count(origin_circuit_t *circ)
/* Check to see if the shouldcount result has changed due to a /* Check to see if the shouldcount result has changed due to a
* unexpected purpose change that would affect our results */ * unexpected purpose change that would affect our results */
if (circ->pathbias_shouldcount == PATHBIAS_SHOULDCOUNT_IGNORED) { if (circ->pathbias_shouldcount == PATHBIAS_SHOULDCOUNT_IGNORED) {
log_info(LD_BUG, log_info(LD_CIRC,
"Circuit %d is now being counted despite being ignored " "Circuit %d is not being counted by pathbias because it was "
"in the past. Purpose is %s, path state is %s", "ignored in the past. Purpose is %s, path state is %s",
circ->global_identifier, circ->global_identifier,
circuit_purpose_to_string(circ->base_.purpose), circuit_purpose_to_string(circ->base_.purpose),
pathbias_state_to_string(circ->path_state)); pathbias_state_to_string(circ->path_state));
return 0;
} }
circ->pathbias_shouldcount = PATHBIAS_SHOULDCOUNT_COUNTED; circ->pathbias_shouldcount = PATHBIAS_SHOULDCOUNT_COUNTED;