mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-27 22:03:31 +01:00
Pathbias should continue to ignore previously ignored circs.
If circuit padding wants to keep a circuit open and pathbias used to ignore it, pathbias should continue to ignore it. This may catch other purpose-change related miscounts (such as timeout measurement, cannibalization, onion service circuit transitions, and vanguards).
This commit is contained in:
parent
5cc988a947
commit
b98bcd789e
@ -400,12 +400,13 @@ pathbias_should_count(origin_circuit_t *circ)
|
||||
/* Check to see if the shouldcount result has changed due to a
|
||||
* unexpected purpose change that would affect our results */
|
||||
if (circ->pathbias_shouldcount == PATHBIAS_SHOULDCOUNT_IGNORED) {
|
||||
log_info(LD_BUG,
|
||||
"Circuit %d is now being counted despite being ignored "
|
||||
"in the past. Purpose is %s, path state is %s",
|
||||
circ->global_identifier,
|
||||
circuit_purpose_to_string(circ->base_.purpose),
|
||||
pathbias_state_to_string(circ->path_state));
|
||||
log_info(LD_CIRC,
|
||||
"Circuit %d is not being counted by pathbias because it was "
|
||||
"ignored in the past. Purpose is %s, path state is %s",
|
||||
circ->global_identifier,
|
||||
circuit_purpose_to_string(circ->base_.purpose),
|
||||
pathbias_state_to_string(circ->path_state));
|
||||
return 0;
|
||||
}
|
||||
circ->pathbias_shouldcount = PATHBIAS_SHOULDCOUNT_COUNTED;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user