nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-11 05:03:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Document the purpose argument of circuit_find_to_cannibalize

Browse Source 
svn:r17689
This commit is contained in:
Nick Mathewson 2008-12-18 17:18:14 +00:00
parent b6f89a647a
commit b91335117f
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/or/circuitlist.c
View File

@ -866,18 +866,16 @@ circuit_get_intro_point(const char *digest)
* flags in <b>flags</b>, and if info is defined, does not already use info * flags in <b>flags</b>, and if info is defined, does not already use info
* as any of its hops; or NULL if no circuit fits this description. * as any of its hops; or NULL if no circuit fits this description.
* *
* The <b>purpose</b> argument (currently ignored) refers to the purpose of
* the circuit we want to create, not the purpose of the circuit we want to
* cannibalize.
*
* If !CIRCLAUNCH_NEED_UPTIME, prefer returning non-uptime circuits. * If !CIRCLAUNCH_NEED_UPTIME, prefer returning non-uptime circuits.
*/ */
origin_circuit_t * origin_circuit_t *
circuit_find_to_cannibalize(uint8_t purpose, extend_info_t *info, circuit_find_to_cannibalize(uint8_t purpose, extend_info_t *info,
int flags) int flags)
{ {
/* XXXX021 arma: The purpose argument is ignored. Can that possibly be
* right? */
/* XXXX <arma> i don't know of any actual bugs that this causes. since i
* think we only call the function for purposes where we want it to do what
* the function does. somebody should check this though. */
circuit_t *_circ; circuit_t *_circ;
origin_circuit_t *best=NULL; origin_circuit_t *best=NULL;
int need_uptime = (flags & CIRCLAUNCH_NEED_UPTIME) != 0; int need_uptime = (flags & CIRCLAUNCH_NEED_UPTIME) != 0;