nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 21:23:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Treat a bad tor_spawn_background() as a BUG().

Browse Source 
The contract is that, if may_spawn_background_process() is 0, you're
not even allowed to try to spawn a process.
This commit is contained in:
Nick Mathewson 2017-08-09 10:55:30 -04:00
parent 5fa8d05bfa
commit b4963da987
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/util.c
View File

@ -4180,8 +4180,11 @@ tor_spawn_background(const char *const filename, const char **argv,
process_environment_t *env,
process_handle_t **process_handle_out)
{
if (may_spawn_background_process == 0)
if (BUG(may_spawn_background_process == 0)) {
/* We should never reach this point if we're forbidden to spawn
* processes. Instead we should have caught the attempt earlier. */
return PROCESS_STATUS_ERROR;
}
#ifdef _WIN32
HANDLE stdout_pipe_read = NULL;