mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-10 13:13:44 +01:00
Fix a compilation warning introduced by clang 3.6
There was a dead check when we made sure that an array member of a struct was non-NULL. Tor has been doing this check since at least 0.2.3, maybe earlier. Fixes bug 17781.
This commit is contained in:
parent
dbb919cf94
commit
b0867fec96
3
changes/bug17781
Normal file
3
changes/bug17781
Normal file
@ -0,0 +1,3 @@
|
||||
o Compilation fixes:
|
||||
- Fix a compilation warning with Clang 3.6: Do not check the
|
||||
presence of an address which can never be NULL. Fixes bug 17781.
|
@ -748,7 +748,7 @@ connection_ap_fail_onehop(const char *failed_digest,
|
||||
/* we don't know the digest; have to compare addr:port */
|
||||
tor_addr_t addr;
|
||||
if (!build_state || !build_state->chosen_exit ||
|
||||
!entry_conn->socks_request || !entry_conn->socks_request->address)
|
||||
!entry_conn->socks_request)
|
||||
continue;
|
||||
if (tor_addr_parse(&addr, entry_conn->socks_request->address)<0 ||
|
||||
!tor_addr_eq(&build_state->chosen_exit->addr, &addr) ||
|
||||
|
Loading…
Reference in New Issue
Block a user