nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-20 21:16:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

kist: When readding chans, check correct chan's sched_heap_idx

Browse Source 
Closes #29508

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
Matt Traudt 2019-02-14 16:18:58 -05:00 committed by David Goulet
parent 6c173d00f5
commit b054a6c6b9
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changes/bug29508 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (scheduler):
- When readding channels to the pending list, check the correct channel's
sched_heap_idx. Fixes bug 29508; bugfix on 0.3.2.10

2
src/core/or/scheduler_kist.c
View File

@ -724,7 +724,7 @@ kist_scheduler_run(void)
SMARTLIST_FOREACH_BEGIN(to_readd, channel_t *, readd_chan) {
scheduler_set_channel_state(readd_chan, SCHED_CHAN_PENDING);
if (!smartlist_contains(cp, readd_chan)) {
if (!SCHED_BUG(chan->sched_heap_idx != -1, chan)) {
if (!SCHED_BUG(readd_chan->sched_heap_idx != -1, readd_chan)) {
/* XXXX Note that the check above is in theory redundant with
* the smartlist_contains check. But let's make sure we're
* not messing anything up, and leave them both for now. */