nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 21:23:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reset buf after each succesful test to avoid artifacts.

Browse Source 
This patch resets `buf` in test_util_fgets_eagain() after each succesful
ivocation to avoid stray artifacts left in the buffer by erroneous
tor_fgets() calls.
This commit is contained in:
Alexander Færøy 2017-02-27 15:57:08 +01:00
parent 3dca5a6e71
commit ae91e64fa8
No known key found for this signature in database
GPG Key ID: E15081D5D3C3DB53
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/test_util.c
View File

@ -3986,6 +3986,7 @@ test_util_fgets_eagain(void *ptr)
tt_ptr_op(retptr, OP_EQ, buf);
tt_str_op(buf, OP_EQ, "B\n");
errno = 0;
memset(buf, '\0', sizeof(buf));
/* Send in a full line */
retlen = write(test_pipe[1], "CD\n", 3);
@ -3995,6 +3996,7 @@ test_util_fgets_eagain(void *ptr)
tt_ptr_op(retptr, OP_EQ, buf);
tt_str_op(buf, OP_EQ, "CD\n");
errno = 0;
memset(buf, '\0', sizeof(buf));
/* Send in a partial line */
retlen = write(test_pipe[1], "E", 1);
@ -4013,6 +4015,7 @@ test_util_fgets_eagain(void *ptr)
tt_ptr_op(retptr, OP_EQ, buf);
tt_str_op(buf, OP_EQ, "F\n");
errno = 0;
memset(buf, '\0', sizeof(buf));
/* Send in a full line and close */
retlen = write(test_pipe[1], "GH", 2);
@ -4036,6 +4039,7 @@ test_util_fgets_eagain(void *ptr)
/* Check that buf is unchanged according to C99 and C11 */
tt_str_op(buf, OP_EQ, "GH");
memset(buf, '\0', sizeof(buf));
done:
if (test_stream != NULL)