nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 06:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix a breakage in test_options.c.

Browse Source 
IMO, these tests should be calling options_init() to properly set everything
to default values, but when that is done, about a dozen tests fail. Setting
the one default value that broke the tests for my branch. Sorry for being
lame.
This commit is contained in:
Mike Perry 2016-09-22 17:35:33 -04:00 committed by Nick Mathewson
parent 20a3d4efac
commit ae4d8c9c74
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/test_options.c
View File

@ -354,6 +354,12 @@ get_options_test_data(const char *conf)
result->opt = options_new(); result->opt = options_new();
result->old_opt = options_new(); result->old_opt = options_new();
result->def_opt = options_new(); result->def_opt = options_new();
// XXX: Really, all of these options should be set to defaults
// with options_init(), but about a dozen tests break when I do that.
// Being kinda lame and just fixing the immedate breakage for now..
result->opt->ConnectionPadding = -1; // default must be "auto"
rv = config_get_lines(conf, &cl, 1); rv = config_get_lines(conf, &cl, 1);
tt_assert(rv == 0); tt_assert(rv == 0);
rv = config_assign(&options_format, result->opt, cl, 0, &msg); rv = config_assign(&options_format, result->opt, cl, 0, &msg);