r9723@catbus: nickm | 2007-01-22 15:47:17 -0500

Fix an XXXX012 in routerlist.c: when we do not have enough networkstatuses to launch router requests, do not launch router requests. Backport candidate.


svn:r9388
This commit is contained in:
Nick Mathewson 2007-01-22 20:57:26 +00:00
parent 9f733c31cc
commit adc5bb4d04
2 changed files with 5 additions and 1 deletions

View File

@ -39,6 +39,10 @@ Changes in version 0.1.2.7-alpha - 2007-??-??
correct order. correct order.
- Free memory held in recently-completed DNS lookup attempts on exit. - Free memory held in recently-completed DNS lookup attempts on exit.
This was not a memory leak, but may have been hiding memory leaks. This was not a memory leak, but may have been hiding memory leaks.
- Don't launch requests for descriptors unless we have networkstatuses
from at least half of the authorities. This delays the first download
slightly under pathological circumstances, but can prevent us from
downloading a bunch of descriptors we don't need.
o Minor features: o Minor features:
- Check for addresses with invalid characters at the exit as well as at - Check for addresses with invalid characters at the exit as well as at

View File

@ -3765,7 +3765,7 @@ update_router_descriptor_client_downloads(time_t now)
smartlist_len(networkstatus_list) <= get_n_v2_authorities()/2) { smartlist_len(networkstatus_list) <= get_n_v2_authorities()/2) {
log_info(LD_DIR, log_info(LD_DIR,
"Not enough networkstatus documents to launch requests."); "Not enough networkstatus documents to launch requests.");
/* XXX012 should we return here or something? */ return;
} }
downloadable = router_list_client_downloadable(); downloadable = router_list_client_downloadable();