From 3d160b37c234e3a26d93c5dad0dbd5137ddfd469 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20F=C3=A6r=C3=B8y?= Date: Thu, 14 Sep 2023 22:26:41 +0200 Subject: [PATCH] Lower the log-level and soften the language for our Zstd ABI compat check. See: tpo/core/tor#40815. --- changes/ticket40815 | 4 ++++ src/lib/compress/compress_zstd.c | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 changes/ticket40815 diff --git a/changes/ticket40815 b/changes/ticket40815 new file mode 100644 index 0000000000..88129b7bb1 --- /dev/null +++ b/changes/ticket40815 @@ -0,0 +1,4 @@ + o Minor bugfixes (compression, zstd): + - Use less frightening language and lower the log-level of our run-time ABI + compatibility check message in our Zstd compression subsystem. Fixes bug + 40815; bugfix on 0.4.3.1-alpha. diff --git a/src/lib/compress/compress_zstd.c b/src/lib/compress/compress_zstd.c index 85c2bb3bfa..9b18930d16 100644 --- a/src/lib/compress/compress_zstd.c +++ b/src/lib/compress/compress_zstd.c @@ -522,9 +522,10 @@ tor_zstd_warn_if_version_mismatched(void) tor_zstd_format_version(runtime_version, sizeof(runtime_version), ZSTD_versionNumber()); - log_warn(LD_GENERAL, + log_info(LD_GENERAL, "Tor was compiled with zstd %s, but is running with zstd %s. " - "For safety, we'll avoid using advanced zstd functionality.", + "For ABI compatibility reasons, we'll avoid using advanced zstd " + "functionality.", header_version, runtime_version); } #endif /* defined(HAVE_ZSTD) && defined(ENABLE_ZSTD_ADVANCED_APIS) */