nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'dgoulet/bug14554_026_v1'

Browse Source
This commit is contained in:
Nick Mathewson 2015-01-30 15:29:59 -05:00
commit aba90b2125
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
changes/bug14554 Normal file
View File

@ -0,0 +1,4 @@
o Major bugfix
- Possibility of an infinite loop if the returned value of the read/recv
was 0. A returned value of 0 means that we've reached the EOF thus the
pipe/sock is drained so return success not an error.

16
src/common/compat_threads.c
View File

@ -171,10 +171,12 @@ pipe_drain(int fd)
{ {
char buf[32]; char buf[32];
ssize_t r; ssize_t r;
while ((r = read_ni(fd, buf, sizeof(buf))) >= 0) do {
; r = read_ni(fd, buf, sizeof(buf));
if (r == 0 || errno != EAGAIN) } while (r > 0);
if (r < 0 && errno != EAGAIN)
return -1; return -1;
/* A value of r = 0 means EOF on the fd so successfully drained. */
return 0; return 0;
} }
#endif #endif
@ -193,10 +195,12 @@ sock_drain(tor_socket_t fd)
{ {
char buf[32]; char buf[32];
ssize_t r; ssize_t r;
while ((r = recv_ni(fd, buf, sizeof(buf), 0)) >= 0) do {
; r = recv_ni(fd, buf, sizeof(buf), 0);
if (r == 0 || !ERRNO_IS_EAGAIN(tor_socket_errno(fd))) } while (r > 0);
if (r < 0 && !ERRNO_IS_EAGAIN(tor_socket_errno(fd)))
return -1; return -1;
/* A value of r = 0 means EOF on the fd so successfully drained. */
return 0; return 0;
} }