nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Zero a cipher completely before freeing it

Browse Source 
We used to only zero the first ptrsize bytes of the cipher. Since
cipher is large enough, we didn't zero too many bytes. Discovered
and fixed by ekir. Fixes bug 1254.
This commit is contained in:
Sebastian Hahn 2010-02-22 11:39:29 +01:00
parent 5e5bc8724e
commit a9802d3322
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
Changes in version 0.2.1.25 - 2010-??-??
o Major bugfixes:
- When freeing a cipher, zero it out completely. We only zeroed
the first ptrsize bytes. Bugfix on tor-0.0.2pre8. Discovered
and patched by ekir. Fixes bug 1254.
Changes in version 0.2.1.24 - 2010-02-21 Changes in version 0.2.1.24 - 2010-02-21
Tor 0.2.1.24 makes Tor work again on the latest OS X -- this time Tor 0.2.1.24 makes Tor work again on the latest OS X -- this time
for sure! for sure!

2
src/common/aes.c
View File

@ -267,7 +267,7 @@ aes_free_cipher(aes_cnt_cipher_t *cipher)
#ifdef USE_OPENSSL_EVP #ifdef USE_OPENSSL_EVP
EVP_CIPHER_CTX_cleanup(&cipher->key); EVP_CIPHER_CTX_cleanup(&cipher->key);
#endif #endif
memset(cipher, 0, sizeof(cipher)); memset(cipher, 0, sizeof(aes_cnt_cipher_t));
tor_free(cipher); tor_free(cipher);
} }