nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 21:23:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Mark one use of networkstatus_check_document_signature as (void)

Browse Source 
Also explain why we aren't checking its return value.

[CID 1198197]
This commit is contained in:
Nick Mathewson 2014-08-21 11:05:59 -04:00
parent 059e33de59
commit a66fff6381
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/or/dirvote.c
View File

@ -2273,8 +2273,11 @@ networkstatus_add_detached_signatures(networkstatus_t *target,
if (!sig->good_signature && !sig->bad_signature) {
cert = authority_cert_get_by_digests(sig->identity_digest,
sig->signing_key_digest);
if (cert)
networkstatus_check_document_signature(target, sig, cert);
if (cert) {
/* Not checking the return value here, since we are going to look
* at the status of sig->good_signature in a moment. */
(void) networkstatus_check_document_signature(target, sig, cert);
}
}
/* If this signature is good, or we don't have any signature yet,