nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 20:33:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix a warning underflow in rend_cache/clean

Browse Source 
Because the test is adding entries to the "rend_cache" directly, the
rend_cache_increment_allocation() was never called which made the
rend_cache_clean() call trigger that underflow warning:

rend_cache/clean: [forking] Nov 29 09:55:04.024 [warn] rend_cache_decrement_allocation(): Bug: Underflow in rend_cache_decrement_allocation (on Tor 0.4.0.0-alpha-dev 2240fe63feb9a8cf)

The test is still good and valid.

Fixes #28660

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2018-11-29 10:02:50 -05:00
parent 9c2b114b2e
commit a51dad4272
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/test_rendcache.c
View File

@ -788,7 +788,9 @@ test_rend_cache_clean(void *data)
desc_two->pk = pk_generate(1); desc_two->pk = pk_generate(1);
strmap_set_lc(rend_cache, "foo1", one); strmap_set_lc(rend_cache, "foo1", one);
rend_cache_increment_allocation(rend_cache_entry_allocation(one));
strmap_set_lc(rend_cache, "foo2", two); strmap_set_lc(rend_cache, "foo2", two);
rend_cache_increment_allocation(rend_cache_entry_allocation(two));
rend_cache_clean(time(NULL), REND_CACHE_TYPE_CLIENT); rend_cache_clean(time(NULL), REND_CACHE_TYPE_CLIENT);
tt_int_op(strmap_size(rend_cache), OP_EQ, 0); tt_int_op(strmap_size(rend_cache), OP_EQ, 0);
@ -806,7 +808,9 @@ test_rend_cache_clean(void *data)
desc_one->pk = pk_generate(0); desc_one->pk = pk_generate(0);
desc_two->pk = pk_generate(1); desc_two->pk = pk_generate(1);
rend_cache_increment_allocation(rend_cache_entry_allocation(one));
strmap_set_lc(rend_cache, "foo1", one); strmap_set_lc(rend_cache, "foo1", one);
rend_cache_increment_allocation(rend_cache_entry_allocation(two));
strmap_set_lc(rend_cache, "foo2", two); strmap_set_lc(rend_cache, "foo2", two);
rend_cache_clean(time(NULL), REND_CACHE_TYPE_CLIENT); rend_cache_clean(time(NULL), REND_CACHE_TYPE_CLIENT);