nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Check the return value of hs_parse_address().

Browse Source 
This patch adds a check for the return value of `hs_parse_address()` in
`hs_control_hspost_command()`. Since it should not be possible for
`hs_parse_address()` to fail in this context we wrap the error check
with the `BUG()` macro.

See: https://bugs.torproject.org/24543
This commit is contained in:
Alexander Færøy 2017-12-06 14:52:02 +01:00
parent 01700d779c
commit 9fa38bd996
No known key found for this signature in database
GPG Key ID: E15081D5D3C3DB53
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/or/hs_control.c
View File

@ -222,7 +222,9 @@ hs_control_hspost_command(const char *body, const char *onion_address,
/* This can't fail because we require the caller to pass us a valid onion
* address that has passed hs_address_is_valid(). */
hs_parse_address(onion_address, &identity_pk, NULL, NULL);
if (BUG(hs_parse_address(onion_address, &identity_pk, NULL, NULL) < 0)) {
goto done; // LCOV_EXCL_LINE
}
/* Only decode the plaintext part which is what the directory will do to
* validate before caching. */