nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove a needless memset() in get_token_arguments()

Browse Source 
I believe we originally added this for "just in case" safety, but it
isn't actually needed -- we never copy uninitialized stack here.
What's more, this one memset is showing up on our startup profiles,
so we ought to remove it.

Closes ticket 28852.
This commit is contained in:
Nick Mathewson 2018-12-14 14:48:12 -05:00
parent f8dac5c900
commit 9dc53bc68f
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
changes/ticket28852 Normal file
View File

@ -0,0 +1,4 @@
o Minor features (performance):
- Remove a needless memset() call from get_token_arguments,
thereby speeding up the tokenization of directory objects by about
20%. Closes ticket 28852.

1
src/feature/dirparse/parsecommon.c
View File

@ -169,7 +169,6 @@ get_token_arguments(memarea_t *area, directory_token_t *tok,
char *cp = mem; char *cp = mem;
int j = 0; int j = 0;
char *args[MAX_ARGS]; char *args[MAX_ARGS];
memset(args, 0, sizeof(args));
while (*cp) { while (*cp) {
if (j == MAX_ARGS) if (j == MAX_ARGS)
return -1; return -1;