nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

scan-build: truncate tinytest hexified outputs to 1024 bytes.

Browse Source 
scan-build didn't like the unlimited version since we might need to
overflow size_t to hexify a string that took up half our address
space. (!)
This commit is contained in:
Nick Mathewson 2014-04-19 12:44:31 -04:00
parent 4d51dcda2f
commit 9c9e07963d
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ext/tinytest.c
View File

@ -478,16 +478,23 @@ tinytest_format_hex_(const void *val_, unsigned long len)
const unsigned char *val = val_;
char *result, *cp;
size_t i;
int ellipses = 0;
if (!val)
return strdup("null");
if (!(result = malloc(len*2+1)))
if (len > 1024) {
ellipses = 3;
len = 1024;
}
if (!(result = malloc(len*2+4)))
return strdup("<allocation failure>");
cp = result;
for (i=0;i<len;++i) {
*cp++ = "0123456789ABCDEF"[val[i] >> 4];
*cp++ = "0123456789ABCDEF"[val[i] & 0x0f];
}
while (ellipses--)
*cp++ = '.';
*cp = 0;
return result;
}