Fix a memory leak in reading an expired ed signing key.

Closes 17403.
This commit is contained in:
Nick Mathewson 2015-10-21 11:16:28 -04:00
parent 5d45a26f39
commit 9c4a0aef0c
2 changed files with 5 additions and 0 deletions

3
changes/bug17403 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (memory leaks):
- Fix a memory leak when reading an expired signing key from disk.
Fixes bug 17403; bugfix on 0.2.7.2-rc.

View File

@ -836,6 +836,8 @@ load_ed_keys(const or_options_t *options, time_t now)
INIT_ED_KEY_INCLUDE_SIGNING_KEY_IN_CERT); INIT_ED_KEY_INCLUDE_SIGNING_KEY_IN_CERT);
char *fname = char *fname =
options_get_datadir_fname2(options, "keys", "ed25519_signing"); options_get_datadir_fname2(options, "keys", "ed25519_signing");
ed25519_keypair_free(sign);
tor_cert_free(sign_cert);
sign = ed_key_init_from_file(fname, sign = ed_key_init_from_file(fname,
flags, LOG_WARN, flags, LOG_WARN,
sign_signing_key_with_id, now, sign_signing_key_with_id, now,