nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 14:23:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid sketchy integer cast in cbt code

Browse Source 
When calling circuit_build_times_shuffle_and_store_array, we were
passing a uint32_t as an int.  arma is pretty sure that this can't
actually cause a bug, because of checks elsewhere in the code, but
it's best not to pass a uint32_t as an int anyway.

Found by doorss; fix on 0.2.2.4-alpha.
This commit is contained in:
Nick Mathewson 2011-01-25 17:27:25 -05:00
parent 7a446e6754
commit 9a4b2ec764
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/or/circuitbuild.c
View File

@ -588,9 +588,9 @@ circuit_build_times_update_state(circuit_build_times_t *cbt,
static void static void
circuit_build_times_shuffle_and_store_array(circuit_build_times_t *cbt, circuit_build_times_shuffle_and_store_array(circuit_build_times_t *cbt,
build_time_t *raw_times, build_time_t *raw_times,
int num_times) uint32_t num_times)
{ {
int n = num_times; uint32_t n = num_times;
if (num_times > CBT_NCIRCUITS_TO_OBSERVE) { if (num_times > CBT_NCIRCUITS_TO_OBSERVE) {
log_notice(LD_CIRC, "Decreasing circuit_build_times size from %d to %d", log_notice(LD_CIRC, "Decreasing circuit_build_times size from %d to %d",
num_times, CBT_NCIRCUITS_TO_OBSERVE); num_times, CBT_NCIRCUITS_TO_OBSERVE);