reject tor-resolve requests for .onion addresses early

svn:r2174
This commit is contained in:
Roger Dingledine 2004-08-07 00:19:14 +00:00
parent 810ebc80d0
commit 9952b37456

View File

@ -401,11 +401,20 @@ static int connection_ap_handshake_process_socks(connection_t *conn) {
return connection_ap_handshake_attach_circuit(conn);
} else {
/* it's a hidden-service request */
/* XXX008 what does it mean to socks-resolve a hidden service? should
* we fail those right here? */
rend_cache_entry_t *entry;
int r;
if (socks->command == SOCKS_COMMAND_RESOLVE) {
/* if it's a resolve request, fail it right now, rather than
* building all the circuits and then realizing it won't work. */
connection_ap_handshake_socks_resolved(conn,RESOLVED_TYPE_ERROR,0,NULL);
conn->socks_request->has_finished = 1;
conn->has_sent_end = 1;
connection_mark_for_close(conn);
conn->hold_open_until_flushed = 1;
return 0;
}
strcpy(conn->rend_query, socks->address); /* this strcpy is safe -RD */
log_fn(LOG_INFO,"Got a hidden service request for ID '%s'", conn->rend_query);
/* see if we already have it cached */