diff --git a/changes/bug9928 b/changes/bug9928
new file mode 100644
index 0000000000..b72cea3d87
--- /dev/null
+++ b/changes/bug9928
@@ -0,0 +1,6 @@
+ o Minor bugfixes:
+ - Avoid an off-by-one error when checking buffer boundaries when
+ formatting the exit status of a pluggable transport helper.
+ This is probably not an exploitable bug, but better safe than
+ sorry. Fixes bug 9928; bugfix on 0.2.3.18-rc. Bug found by
+ Pedro Ribeiro.
diff --git a/src/common/util.c b/src/common/util.c
index a45011fc4c..51d1352810 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -3448,10 +3448,10 @@ format_hex_number_sigsafe(unsigned int x, char *buf, int buf_len)
* hex_errno. Called between fork and _exit, so must be signal-handler
* safe.
*
- * hex_errno must have at least HEX_ERRNO_SIZE bytes available.
+ * hex_errno must have at least HEX_ERRNO_SIZE+1 bytes available.
*
* The format of hex_errno is: "CHILD_STATE/ERRNO\n", left-padded
- * with spaces. Note that there is no trailing \0. CHILD_STATE indicates where
+ * with spaces. CHILD_STATE indicates where
* in the processs of starting the child process did the failure occur (see
* CHILD_STATE_* macros for definition), and SAVED_ERRNO is the value of
* errno when the failure occurred.
@@ -3529,8 +3529,8 @@ format_helper_exit_status(unsigned char child_state, int saved_errno,
left -= written;
cur += written;
- /* Check that we have enough space left for a newline */
- if (left <= 0)
+ /* Check that we have enough space left for a newline and a NUL */
+ if (left <= 1)
goto err;
/* Emit the newline and NUL */
@@ -3786,7 +3786,7 @@ tor_spawn_background(const char *const filename, const char **argv,
this is used for printing out the error message */
unsigned char child_state = CHILD_STATE_INIT;
- char hex_errno[HEX_ERRNO_SIZE];
+ char hex_errno[HEX_ERRNO_SIZE + 1];
static int max_fd = -1;