Fix the fencepost issue when we check stability_last_downrated

This commit is contained in:
Neel Chauhan 2021-05-20 11:06:50 -07:00
parent e247aab4ec
commit 96b59fc4d3
2 changed files with 5 additions and 1 deletions

4
changes/bug40394 Normal file
View File

@ -0,0 +1,4 @@
o Minor bugfixes (statistics):
- Fix the fencepost issue when we check stability_last_downrated where
we call rep_hist_downrate_old_runs() twice. Fixes bug 40394; bugfix
on 0.2.0.5-alpha. Patch by Neel Chauhan.

View File

@ -731,7 +731,7 @@ rep_hist_downrate_old_runs(time_t now)
return stability_last_downrated + STABILITY_INTERVAL; return stability_last_downrated + STABILITY_INTERVAL;
/* Okay, we should downrate the data. By how much? */ /* Okay, we should downrate the data. By how much? */
while (stability_last_downrated + STABILITY_INTERVAL < now) { while (stability_last_downrated + STABILITY_INTERVAL <= now) {
stability_last_downrated += STABILITY_INTERVAL; stability_last_downrated += STABILITY_INTERVAL;
alpha *= STABILITY_ALPHA; alpha *= STABILITY_ALPHA;
} }