nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove FIXME about comparing num countries,

Browse Source 
* remove the fixme since clearing the countries should be other issue
* remove unused variables related to it since that cause travis to fail
This commit is contained in:
juga0 2018-04-17 16:38:24 +00:00 committed by David Goulet
parent 6a28a82998
commit 96469b82f8
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/test/test_geoip.c
View File

@ -511,16 +511,10 @@ test_geoip_load_2nd_file(void *arg)
const char FNAME[] = SRCDIR "/src/config/geoip"; const char FNAME[] = SRCDIR "/src/config/geoip";
tt_int_op(0, OP_EQ, geoip_load_file(AF_INET, FNAME)); tt_int_op(0, OP_EQ, geoip_load_file(AF_INET, FNAME));
int num_countries_geoip = geoip_get_n_countries();
/* Load 2nd geoip (empty) file */ /* Load 2nd geoip (empty) file */
const char FNAME2[] = SRCDIR "/src/test/geoip_dummy"; const char FNAME2[] = SRCDIR "/src/test/geoip_dummy";
tt_int_op(0, OP_EQ, geoip_load_file(AF_INET, FNAME2)); tt_int_op(0, OP_EQ, geoip_load_file(AF_INET, FNAME2));
int num_countries_geoip2 = geoip_get_n_countries();
/* FIXME: should not this be different? */
/* tt_int_op(num_countries_geoip, OP_NE, num_countries_geoip2); */
/* Check that there is no geoip information for 8.8.8.8, */ /* Check that there is no geoip information for 8.8.8.8, */
/* since loading the empty 2nd file should have delete it. */ /* since loading the empty 2nd file should have delete it. */
int country = geoip_get_country_by_ipv4(0x08080808); int country = geoip_get_country_by_ipv4(0x08080808);
@ -551,4 +545,3 @@ struct testcase_t geoip_tests[] = {
END_OF_TESTCASES END_OF_TESTCASES
}; };