Make a bunch of networkstatus_t parameters constant.

This is part of refactoring our "notify the rest of the code that we
have a new consensus" code.
This commit is contained in:
Nick Mathewson 2020-06-24 14:28:43 -04:00
parent 86da0cfd36
commit 93ccb3294b
6 changed files with 9 additions and 10 deletions

View File

@ -90,7 +90,7 @@ static int consensus_nf_pad_single_onion;
* for every single connection, every second. * for every single connection, every second.
*/ */
void void
channelpadding_new_consensus_params(networkstatus_t *ns) channelpadding_new_consensus_params(const networkstatus_t *ns)
{ {
#define DFLT_NETFLOW_INACTIVE_KEEPALIVE_LOW 1500 #define DFLT_NETFLOW_INACTIVE_KEEPALIVE_LOW 1500
#define DFLT_NETFLOW_INACTIVE_KEEPALIVE_HIGH 9500 #define DFLT_NETFLOW_INACTIVE_KEEPALIVE_HIGH 9500

View File

@ -37,7 +37,6 @@ int channelpadding_send_enable_command(channel_t *chan, uint16_t low_timeout,
int channelpadding_get_circuits_available_timeout(void); int channelpadding_get_circuits_available_timeout(void);
unsigned int channelpadding_get_channel_idle_timeout(const channel_t *, int); unsigned int channelpadding_get_channel_idle_timeout(const channel_t *, int);
void channelpadding_new_consensus_params(networkstatus_t *ns); void channelpadding_new_consensus_params(const networkstatus_t *ns);
#endif /* !defined(TOR_CHANNELPADDING_H) */ #endif /* !defined(TOR_CHANNELPADDING_H) */

View File

@ -399,7 +399,7 @@ circuit_build_times_initial_timeout(void)
* and learn a new timeout. * and learn a new timeout.
*/ */
static int32_t static int32_t
circuit_build_times_recent_circuit_count(networkstatus_t *ns) circuit_build_times_recent_circuit_count(const networkstatus_t *ns)
{ {
int32_t num; int32_t num;
num = networkstatus_get_param(ns, "cbtrecentcount", num = networkstatus_get_param(ns, "cbtrecentcount",
@ -425,7 +425,7 @@ circuit_build_times_recent_circuit_count(networkstatus_t *ns)
*/ */
void void
circuit_build_times_new_consensus_params(circuit_build_times_t *cbt, circuit_build_times_new_consensus_params(circuit_build_times_t *cbt,
networkstatus_t *ns) const networkstatus_t *ns)
{ {
int32_t num; int32_t num;

View File

@ -43,7 +43,7 @@ int circuit_build_times_needs_circuits_now(const circuit_build_times_t *cbt);
void circuit_build_times_init(circuit_build_times_t *cbt); void circuit_build_times_init(circuit_build_times_t *cbt);
void circuit_build_times_free_timeouts(circuit_build_times_t *cbt); void circuit_build_times_free_timeouts(circuit_build_times_t *cbt);
void circuit_build_times_new_consensus_params(circuit_build_times_t *cbt, void circuit_build_times_new_consensus_params(circuit_build_times_t *cbt,
networkstatus_t *ns); const networkstatus_t *ns);
double circuit_build_times_timeout_rate(const circuit_build_times_t *cbt); double circuit_build_times_timeout_rate(const circuit_build_times_t *cbt);
double circuit_build_times_close_rate(const circuit_build_times_t *cbt); double circuit_build_times_close_rate(const circuit_build_times_t *cbt);

View File

@ -621,7 +621,7 @@ get_estimated_address_per_node, (void))
* and grab microdescriptors into nodes as appropriate. * and grab microdescriptors into nodes as appropriate.
*/ */
void void
nodelist_set_consensus(networkstatus_t *ns) nodelist_set_consensus(const networkstatus_t *ns)
{ {
const or_options_t *options = get_options(); const or_options_t *options = get_options();
int authdir = authdir_mode_v3(options); int authdir = authdir_mode_v3(options);
@ -952,7 +952,7 @@ nodelist_assert_ok(void)
/** Ensure that the nodelist has been created with the most recent consensus. /** Ensure that the nodelist has been created with the most recent consensus.
* If that's not the case, make it so. */ * If that's not the case, make it so. */
void void
nodelist_ensure_freshness(networkstatus_t *ns) nodelist_ensure_freshness(const networkstatus_t *ns)
{ {
tor_assert(ns); tor_assert(ns);

View File

@ -32,8 +32,8 @@ const node_t *node_get_by_hex_id(const char *identity_digest,
unsigned flags); unsigned flags);
node_t *nodelist_set_routerinfo(routerinfo_t *ri, routerinfo_t **ri_old_out); node_t *nodelist_set_routerinfo(routerinfo_t *ri, routerinfo_t **ri_old_out);
node_t *nodelist_add_microdesc(microdesc_t *md); node_t *nodelist_add_microdesc(microdesc_t *md);
void nodelist_set_consensus(networkstatus_t *ns); void nodelist_set_consensus(const networkstatus_t *ns);
void nodelist_ensure_freshness(networkstatus_t *ns); void nodelist_ensure_freshness(const networkstatus_t *ns);
int nodelist_probably_contains_address(const tor_addr_t *addr); int nodelist_probably_contains_address(const tor_addr_t *addr);
void nodelist_add_addr4_to_address_set(const uint32_t addr); void nodelist_add_addr4_to_address_set(const uint32_t addr);
void nodelist_add_addr6_to_address_set(const tor_addr_t *addr); void nodelist_add_addr6_to_address_set(const tor_addr_t *addr);