Another attempt at fixing coverity scan CID 361.

svn:r17863
This commit is contained in:
Nick Mathewson 2009-01-03 23:06:12 +00:00
parent d3e57378ec
commit 9201586ed5

View File

@ -3295,7 +3295,8 @@ routerlist_remove_old_routers(void)
* decide to kill routers.) */
/* XXX021 we don't check if we have a v3 consensus, do we? should we? -RD */
if (!caches ||
smartlist_len(networkstatus_v2_list) > get_n_v2_authorities() / 2) {
(networkstatus_v2_list &&
smartlist_len(networkstatus_v2_list) > get_n_v2_authorities() / 2)) {
cutoff = now - ROUTER_MAX_AGE;
/* Remove too-old unrecommended members of routerlist->routers. */
for (i = 0; i < smartlist_len(routerlist->routers); ++i) {