nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

channel: Rewrite the channel_get_for_extend() comments

Browse Source 
Explain what the function does now.
Fix some typos.

Part of 33633.
This commit is contained in:
teor 2020-04-06 19:11:17 +10:00
parent 7bc3413322
commit 8f3cbe755b
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/core/or/channel.c
View File

@ -2360,12 +2360,15 @@ channel_is_better(channel_t *a, channel_t *b)
/** /**
* Get a channel to extend a circuit. * Get a channel to extend a circuit.
* *
* Pick a suitable channel to extend a circuit to given the desired digest * Given the desired relay identity, pick a suitable channel to extend a
* the address we believe is correct for that digest; this tries to see * circuit to the target address requsted by the client. Search for an
* if we already have one for the requested endpoint, but if there is no good * existing channel for the requested endpoint. Make sure the channel is
* channel, set *msg_out to a message describing the channel's state * usable for new circuits, and matches the target address.
* and our next action, and set *launch_out to a boolean indicated whether *
* the caller should try to launch a new channel with channel_connect(). * Try to return the best channel. But if there is no good channel, set
* *msg_out to a message describing the channel's state and our next action,
* and set *launch_out to a boolean indicated whether the caller should try to
* launch a new channel with channel_connect().
*/ */
channel_t * channel_t *
channel_get_for_extend(const char *rsa_id_digest, channel_get_for_extend(const char *rsa_id_digest,
@ -2383,9 +2386,7 @@ channel_get_for_extend(const char *rsa_id_digest,
chan = channel_find_by_remote_identity(rsa_id_digest, ed_id); chan = channel_find_by_remote_identity(rsa_id_digest, ed_id);
/* Walk the list, unrefing the old one and refing the new at each /* Walk the list of channels */
* iteration.
*/
for (; chan; chan = channel_next_with_rsa_identity(chan)) { for (; chan; chan = channel_next_with_rsa_identity(chan)) {
tor_assert(tor_memeq(chan->identity_digest, tor_assert(tor_memeq(chan->identity_digest,
rsa_id_digest, DIGEST_LEN)); rsa_id_digest, DIGEST_LEN));