nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 12:23:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Warn when an authority has voted for a version with a space in it.

Browse Source 
Another way to try to prevent a recurrence of 26485.
This commit is contained in:
Nick Mathewson 2018-07-11 11:24:55 -04:00
parent dcee4d4c9c
commit 8ee1fe7aa7
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/or/dirvote.c
View File

@ -673,6 +673,14 @@ compute_consensus_versions_list(smartlist_t *lst, int n_versioning)
int min = n_versioning / 2;
smartlist_t *good = smartlist_new();
char *result;
SMARTLIST_FOREACH_BEGIN(lst, const char *, v) {
if (strchr(v, ' ')) {
log_warn(LD_DIR, "At least one authority has voted for a version %s "
"that contains a space. This probably wasn't intentional, and "
"is likely to cause trouble. Please tell them to stop it.",
escaped(v));
}
} SMARTLIST_FOREACH_END(v);
sort_version_list(lst, 0);
get_frequent_members(good, lst, min);
result = smartlist_join_strings(good, ",", 0, NULL);
@ -4002,4 +4010,3 @@ vote_routerstatus_find_microdesc_hash(char *digest256_out,
}
return -1;
}